-
Notifications
You must be signed in to change notification settings - Fork 22
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
wip: first pass at including space did info in verification email #318
Conversation
I think we should coalesce around gravatars for consistency. Maybe we can also pass the space nickname from browser via UCAN through the protocol like #291 |
Few notes:
|
oo for posterity, I found the quote I was looking for that forms the basis of my feeling that showing the DID to the user is bad:
I don't think there's any disagreement, but worth thinking about in this context: https://github.com/cwebber/rebooting-the-web-of-trust-spring2018/blob/petnames/draft-documents/petnames.md |
d62b846
to
06bf498
Compare
this looks like a small patch that adds some functionality and not much risky. @travis do you think it's still useful? If so we can spend some time tomorrow making the tests pass to merge |
I think we should revisit this after or during implementation of providers and accounts in our current phase. |
closing in favor of the work in #399 |
First pass at including space DID info in verification email, per #259:
I think this is unsatisfactory - DIDs aren't designed to be shown to humans and people will likely mostly ignore them. There are a number of potential solutions:
a) I don't think we save the name outside of the user's browser at the moment (tho could be wrong.. hope I'm wrong?!)
b) users might have multiple spaces with the same name, so this may not be unambiguous
Opening this draft pull request to kick off discussion and design of how we actually want this to work. Please weigh in!