WIP: Don't crash in populate when blockdev plugins are missing. #686
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
dwlehman
force-pushed
the
populate-no-plugins
branch
from
78ec7cb
to
9732209
Compare
|
I'd suggest using the |
dwlehman
force-pushed
the
populate-no-plugins
branch
2 times, most recently
from
b05ee9a
to
9d0bc2c
Compare
dwlehman
force-pushed
the
populate-no-plugins
branch
from
9d0bc2c
to
b056ef6
Compare
|
One thing still needed is to make it clear that these guards are only for query/populate as opposed to being general-purpose. |
|
Nice, I really like this! |
Yeah. Maybe there could be a new |
dwlehman
force-pushed
the
populate-no-plugins
branch
from
b056ef6
to
695dd01
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This was thrown together as quickly as possible on Friday to see what it would take. Now I need to decide how to organize things for a final/real version. Using the existing availability tasks from the device classes is somewhat heavy-handed since we only need query functionality for populating the devicetree, so I am considering creating some new functions in devicelibs that call
BlockDev.foo_is_tech_avail()to determine which functionality is available at runtime.