Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

MAINTAINERS.md: add release notes template #392

Open
wants to merge 4 commits into
base: main
Choose a base branch
from
+14 −4
Open

MAINTAINERS.md: add release notes template #392

Changes from 3 commits
Commits
Show all changes
4 commits
Select commit Hold shift + click to select a range
a469dce
MAINTAINERS.md: add release notes template
neo-cypher Jan 25, 2024
16f580d
Merge branch 'main' into af/maintainers-cltemp
nergdron Jan 29, 2024
d31f69e
Merge branch 'main' into af/maintainers-cltemp
nergdron Jan 31, 2024
599bdae
MAINTAINERS.md: add release notes template
neo-cypher Feb 2, 2024
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
18 changes: 14 additions & 4 deletions MAINTAINERS.md
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -46,9 +46,19 @@ Examples of Release Candidates:
- Cick the `Edit` button on the release.
- Upload all binaries as release artifacts.
- Upload sha256sums as well.
- Add the following line for the description:
```
Docker image: `70cd153-v1.67.0-go1.21.3`
```
- If this is an official release, deselect the `This is a pre-release` checkbox.
- Click the `Update release` button.

## Github Release Template
Be sure to update these items from the template:
- v1.69.0 should be the current release tag.
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

are these versions here examples? I'm not sure I fully understand what it's trying to say

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

same

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

should we just use some generic revisions instead? this feels confusing

- v1.70.2 should be the tag anticipated for release
- current build tag text should be the current build tag, i.e. `d6fc137-v1.70.2-go1.21.3`

```
## Changes
**Full Changelog**: https://github.com/storj/edge/compare/v1.69.0...v1.70.2

## Docker Image
`current build tag`
```