Skip to content

Commit

Permalink
ci: don't call check-downgrades from testsuite
Browse files Browse the repository at this point in the history
Calling check-downgrades from testsuite makes it confuse the top
module's go.mod with the nested module's one. This happens because
check-downgrades cannot easily know it was called from within the nested
module and does not change the directory when it performs the check
against the previous commit's directory. Moreover, this is redundant to
call check-downgrades from the nested module as it can find all the
nested modules when called from the top module.

Change-Id: Ic91b54aea011e9a595bb67ed5e22e72e9175cf6b
  • Loading branch information
amwolff committed Dec 1, 2021
1 parent fe423cd commit 03818a4
Showing 1 changed file with 0 additions and 1 deletion.
1 change: 0 additions & 1 deletion Jenkinsfile
Original file line number Diff line number Diff line change
Expand Up @@ -85,7 +85,6 @@ pipeline {
sh 'check-errs ./...'
sh 'staticcheck ./...'
sh 'golangci-lint run --config /go/ci/.golangci.yml'
sh 'check-downgrades'
sh 'check-mod-tidy -mod ../.build/testsuite.go.mod.orig'
}
}
Expand Down

0 comments on commit 03818a4

Please sign in to comment.