Move int64s to top of struct to resolve alignment issue on ARM #2521
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ethanadams
added
Request Code Review
jtolio
approved these changes
Jul 10, 2019
storagenode/storagenodedb/infodb.go
Outdated
| @@ -44,8 +44,8 @@ func newInfo(path string) (*InfoDB, error) { | |||
| dbutil.Configure(db, mon) | |||
|
|
|||
| infoDb := &InfoDB{db: db} | |||
| infoDb.pieceinfo = pieceinfo{infoDb, spaceUsed{sync.Once{}, 0}} | |||
| infoDb.bandwidthdb = bandwidthdb{infoDb, bandwidthUsed{sync.RWMutex{}, time.Time{}, 0}} | |||
| infoDb.pieceinfo = pieceinfo{infoDb, spaceUsed{0, sync.Once{}}} | |||
There was a problem hiding this comment.
okay for this PR buuuut
definitely a strong preference to not create structs with unnamed, positional fields. always always use named fields in struct creation.
egonelbre
reviewed
Jul 10, 2019
| used int64 | ||
| once sync.Once |
There was a problem hiding this comment.
Add a comment why it's in a different order.
egonelbre
reviewed
Jul 10, 2019
| @@ -22,9 +22,9 @@ type bandwidthdb struct { | |||
| } | |||
|
|
|||
| type bandwidthUsed struct { | |||
| used int64 | |||
There was a problem hiding this comment.
Add a comment why it's in a different order.
jenlij
approved these changes
Jul 10, 2019
littleskunk
pushed a commit
that referenced
this pull request
Jul 10, 2019
* move int64s to top of struct to resolve alignment issue on ARM (cherry picked from commit f06aec0)
The's a known issue with certain 'atomic' methods on 64-bit datatypes on certain ARM processers. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What:
Move int64s used in atomic operations to top of struct
Why:
Resolves alignment issue on ARM (golang/go#23345)
Please describe the tests:
Please describe the performance impact:
Code Review Checklist (to be filled out by reviewer)