Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

pkg/files: Add new vuetify poc UI #94

Open
wants to merge 1 commit into
base: main
Choose a base branch
from
Open

pkg/files: Add new vuetify poc UI #94

wants to merge 1 commit into from

Conversation

littleskunk
Copy link
Member

Still requires storj-up env setenv satellite-api STORJ_CONSOLE_USE_VUETIFY_PROJECT=true
I didn't include that into the PR because it makes more sense to just switch it on by default in the storj repository.

@littleskunk littleskunk requested a review from elek as a code owner October 5, 2023 11:18
@@ -50,6 +50,7 @@ ENV STORJ_STORAGENODE_CONSOLE_STATIC_DIR=/var/lib/storj/web/storagenode
COPY --from=binaries /var/lib/storj/go/bin /var/lib/storj/go/bin
COPY --from=binaries /var/lib/storj/storj/web/satellite/stati[c] /var/lib/storj/storj/web/satellite/static
COPY --from=binaries /var/lib/storj/storj/web/satellite/dis[t] /var/lib/storj/storj/web/satellite/dist
COPY --from=binaries /var/lib/storj/storj/web/satellite/dist_vuetify_poc /var/lib/storj/storj/web/satellite/dist_vuetify_poc
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The brackets are needed here because if you pass in the build arg SKIP_FRONTEND_BUILD=true (which is useful to speed up the build in cases where you just want to test with the satellite and uplink, and don't need the front end build) you will get an error "/var/lib/storj/storj/web/satellite/dist_vuetify_poc": not found. If you add a bracket around the last character to make this line COPY --from=binaries /var/lib/storj/storj/web/satellite/dist_vuetify_po[c] /var/lib/storj/storj/web/satellite/dist_vuetify_poc this tells docker "I only want to copy this folder if it exists. If it doesn't exist, it's not an error, just continue."

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Don't we have the same issue with some lines further down? The admin UI is missing the brackets.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants