fix: update empty state size #522
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
* feat(on-1644): add reset password functionality in org * chore(on-1644): apply pr suggestions * chore(on-1644): apply pr suggestions * fix(on-1644): unit tests * chore(on-1644): update unit tests + add password reset integration support * fix(on-1644): eslint issue * fix(on-1644): typescript issues found * chore(on-1644): add reset user password integration * chore(on-1644): apply pr suggestions * chore(on-1644): show notification on successful reset of password * chore(on-1644): remove select items watcher * fix(on-1644): eslint issues * fix(on-1644): eslint issue * chore(on-1644): reload org data after successful password reset * fix(on-1644): linter issue * fix(on-1644): unit test
* chore: init release tommy 71 * 🤖 ci: refactor pipelines to be more efficient (#5118) * ci: fix linting action * ci: update lint step * ci: update file paths * 🐛 fix(ON-1512): app freeze on loading extension that was not found (#5138) * fix(on-1512): app freeze on loading extension that was not found * chore(on-1512): apply pr suggestion * fix(on-1512): unit tests * 🐛 fix(ON-1631): ignore org role when user is external user (#5143) * fix(on-1631): display correct role when external user is org owner * fix(on-1631): types errors * test(on-1631): add unit test to handle external users * 🐛 fix: copy-paste styled marks in the rich text editor (#5139) * fix: copy-paste styled marks in the rich text editor * ci: fix linting action * ci: adapt file paths * ci: update file paths --------- Co-authored-by: Lisi Linhart <[email protected]> Co-authored-by: sandrodarrieux <[email protected]> Co-authored-by: Gustavo Melki Portaluri <[email protected]> * fix(str-2121): fixing asset file type to enable playing of media in content editor (#5146) * fix(work-1558): fix list stories block quick filter search (#5147) Co-authored-by: Dhiego Bastos <[email protected]> Co-authored-by: Carolina Faria <[email protected]> * chore: update design system to develop branch * test: add data-mark-styled-class (#5160) * chore: update CI testing environment (#5162) * fix(work-1592): add type button (#5148) Co-authored-by: Dhiego Bastos <[email protected]> * fix: gitrepo version * fix(work-1472): fix Workflow Settings name on the Menu list when in Mobile view (#5111) Co-authored-by: Dhiego Bastos <[email protected]> Co-authored-by: Carolina Faria <[email protected]> * 🐛 fix(ON-1634): load org extended external users from different regions (#5151) * fix(on-1634): load org extended users from different regions * chore(on-1634): revert space list mixin file * chore(on-1634): optimize org endpoint load time in teams page * fix(on-1634): unit tests * fix(on-1634): rename enum to follow standards * 🐛 fix(ON-1624): adds navigation guard based on job_role to "My Plugins" page (#5152) * 🐛 fix: edge case error encountered at sign out when external user is empty (#5176) * fix(on-1634): edge case error encountered when external user is not present * fix: apply pr suggestions * fix(on-1572): partner resource order to order content by arrangement (#5167) * ✨ feat(ON-1422): add data-testid for user account form fields (#5166) * refactor(on-1422): use emit to update account state refactor(on-1422): add types for multiple files feat(on-1422): add data-testid for user account form fields * fix(on-1422): unit tests for account component * fix(on-1422): fix type of method * refactor(on-1422): replace multiple methods with only one to update user state * fix(on-1422): use $event on update state * ✨ feat(ON-1420): add data-testid on login form fields (#5175) * feat(on-1420): add data-testid to login fields * refactor(on-1420): move component from index.vue to component.vue * test(work-1624): workflow e2e folder move * test(work-1624): remove old files * test(work-1624): subfolders addition * test(ft-1077): move fieldtypes e2e test * test(ft-1077): fix fieldTypeLink config e2e test * test(str-2145): move to edx general squad folder * test(ON-1665): move to the onboarding squad folder (#5186) Co-authored-by: sandrodarrieux <[email protected]> * fix(work-1587): unable to move a story to the second position using the 'move' functionality (#5183) * chore: update ci for unit testing * 🧪 test(ft-1082): fix editorform and pagehistory config e2e test (#5195) * test(ft-1082): fix editorform and pagehistory config e2e test * test(ft-1082): remove comment * test(ft-1080): fix fieldtypeMultiAsset config e2e test * feat(ON-1425): binds new data test IDs for QA use (#5179) * 🏗️ chore: don't block commits with linting errors (#5193) * chore: prettier --write on pre-commit * chore: run eslint quietly * chore: run eslint quietly * chore: run eslint quietly * chore: try commiting file with error --------- Co-authored-by: Lisi Linhart <[email protected]> * 🏗️ chore: update lint staged and husky library (#5197) * refactor: lint staged setup * refactor: eslint setting * fix: remove plugin * 🏗️ chore(FT-1075): make design system work with workspaces (#5178) Remove the yarn.lock files in the design system. In a monorepo, yarn expects a single yarn.lock file at the root folder. If we want to publish the lock file to https://github.com/storyblok/storyblok-design-system, we'd have to regenerate it. But it might not be needed–in fact, it might event be a benefit in that the user can choose their own package manager. We can deal with this later. Generate declaration files when you build the @storyblok/components library: https://github.com/storyblok/storyfront/pull/5178/files#diff-27f0b79ec5f199bb7b3ae384301adef3dfe13912d43be0e0c9975d79050b5e2bR8. This will not check for type errors. On NPM, we can observe that the declaration files are missing: https://www.npmjs.com/package/@storyblok/design-system?activeTab=code Refer to the declaration files in package.json > types: https://github.com/storyblok/storyfront/pull/5178/files#diff-a4c0abcf0f908370abfbae102f74a6ce5fa6453eac6d389f6fc78cece44782f9R24. In this way, packages that depend on this one can use find the declaration files. In @storyblok/components, include the styles in the preview. These are defined in preview.scss I added SbButton in the storybook preview for the Collapse component to demonstrate that it works: https://github.com/storyblok/storyfront/pull/5178/files#diff-4c8c5a0d24e060d839e41267b4e0e9ab7d267ab4eab270406b7548653318e93aR30 * test(ft-1081): fix fieldtypeMarkdown config e2e test * ✨ feat(FT-1083): implement settings for the Global Reference - Story card appearance settings (#5196) * feat(ft-1083): implement config for preview_card_image field * feat(ft-1083): implement the advanced search parameter in the config * feat(ft-1083): implement logic to select the entry story appearance * feat(ft-1083): add types for the new fields in the multi-options field type * fix(ft-1083): fix vue-tsc error * feat(ft-1083): add the missing SVGs and update the card styles * fix(ft-1083): adjust styles in the multi options field config * fix(ft-1083): make some updates from the code review * refactor(ft-1083): refactor the StoryOptionsStyle component splitting it into small components * fix(ft-1083): update styles for the buttons in StoryOptionStyle component * fix(ft-1083): fix active text color style * feat(ft-1083): adding the tooltip in appearance label --------- Co-authored-by: sandrodarrieux <[email protected]> * 🏗️ chore(ON-1670): improve space users settings tooltip text (#5203) * chore(on-1670): improve text for users settings tooltip * chore: update texting according to PR suggestion * fix(on-1670): use additionalSeats const to differentiate the translation * 🐛 fix(ON-1693): display onboarding steps in demo space after user account is created (#5202) * fix(on-1693): display onboarding steps in demo space once account is created * chore(on-1693): apply pr suggestion * chore: init release max newman 72 * chore: update translations * 🏗️ chore: eslint rules for regex validations (#5208) * ✨ feat(ON-1611): add the subscribed plan in the space card (#5171) * chore(on-1611): add type to tag * feat(on-1611): show space plan name on space card * fix(on-1611): unit test * fix(on-1611): class spelling * fix(on-1611): card info misalignment * fix(on-1611): enterprise plan visibility for space card and typescript warnings * fix(on-1611): make separator background transparent * fix: ci unit testing * fix(on-1611): apply pr suggestions * chore(on-1611): revert workflows file * chore(on-1611): apply pr suggestions --------- Co-authored-by: Lisi Linhart <[email protected]> Co-authored-by: Carolina Faria <[email protected]> * 🏗️ chore(ar-188): refactor color variables (#5163) * fix(ft-1112): fixing alignment in field name label (#5223) * chore(on-1421): add data-testid attribute to sign up and onboarding fields (#5222) refactor(on-1421): change data-testid company-size to onboarding-company-size * 🏗️ ci(ar-233): update e2e ci testing pipeline (#5220) * ♻️ refactor(ar-232): remove old typechecker for better type inference (#5150) * fix: flaky unit test * 🧪 test(ON-1717): refactor elements changes (#5230) * test(ON-1717): refactor elements changes * test(ON-1717): remove only from the test * 🧪 test(ON-1709): refactor account tests (#5225) * test(ON-1709): refactor flaky tests * test(ON-1709): create new user for specifc test * test(ON-1716): refactor flaky tests on partner portal folder (#5227) * chore: sync release with production branch * 🧪 test(str-2158): modify single story schedule test (#5209) * test(str-2158): modify single story schedule test * fix: remove date format and only * fix(str-2158): change SbIcon to SbIconButton in the story filters * fix: added aria label * test: added assertion for responses * test: fix arrangement * fix: test suite name * test: removed comments * fix: .only * test: remove flaky test * test: remove only --------- Co-authored-by: Emanuel Gonçalves <[email protected]> * ✨ feat(FT-1073): advanced search modal in Options field type (#5212) * feat(ft-1083): implement config for preview_card_image field * feat(ft-1083): implement the advanced search parameter in the config * feat(ft-1083): implement logic to select the entry story appearance * feat(ft-1083): add types for the new fields in the multi-options field type * fix(ft-1083): fix vue-tsc error * feat(ft-1083): add the missing SVGs and update the card styles * fix(ft-1083): adjust styles in the multi options field config * fix(ft-1083): make some updates from the code review * refactor(ft-1083): refactor the StoryOptionsStyle component splitting it into small components * fix(ft-1083): update styles for the buttons in StoryOptionStyle component * fix(ft-1083): fix active text color style * feat(ft-1083): adding the tooltip in appearance label * feat: advanced search modal * feat: advanced search modal * fix: ts error * fix: TODO comments * fix: undo types * fix: ts error * fix: ts error * Apply suggestions from code review * fix: ts error * Apply suggestions from code review * fix: spelling * Update src/components/Base/BaseEnhancedSelect/components/StorySearch/StorySearch.vue * Update src/components/Base/BaseEnhancedSelect/index.vue --------- Co-authored-by: Emanuel Gonçalves <[email protected]> Co-authored-by: sandrodarrieux <[email protected]> * fix: focus issue * 🧪 test(work-1652): server setup for e2e (#5231) * test(work-1652): server setup for e2e * test(work-1652): code improvement * Update CreateFolder.ci.specs.js * fix: footer background color * fix: grouped menu item alignment * chore: update command * chore: update translations * fix: background color * chore: action to run all unit tests * fix: position of the new focus * chore: update ci actions for unit tests * fix: nikolas design feedback * fix: menu issues * fix: more design feedback * fix: more design feedback * fix: more design feedback * fix: more design feedback * fix: stylelint report * fix: linting issues * fix: add ignore path * fix: issues with light grey text * fix: small issue on foldout * 🏗️ chore: run prettier again (#5241) * fix: remove invalid prettier options * chore: run prettier --write * chore: undo formatting * chore: run prettier * chore: add script for running eslint-nibble * chore: undo changes * Update src/config.ts * fix: border color import * chore: code ownership for base components (#5248) * ✨ feat(EXT-2150): pass releases and interface language info to field plugins (#5211) * feat(EXT-2150): pass releases and interface language info to field plugins * feat(EXT-2150): remove unnecessary properties from releases * feat(EXT-2150): remove unnecessary comment * feat(EXT-2150): remove unnecessary comment * feat(EXT-2150): add properties to Release * feat(EXT-2150): add releaseId * fix: github action for running all unit tests * fix: remove old typecheck * fix: unit test * 🏗️ chore(ar-259): update vite security issue (#4971) * chore: update vite to 5 * fix: dev dependencies * 🐛 fix: the duplication of org spaces (#5266) * fix: duplication of org spaces * chore: optimize clearing strategy * chore: apply pr suggestion * 🏗️ chore(ar-258): update vue 3.4 (#5263) * chore: update vue version * fix: update vue-i18n mock * chore: update libraries * fix: unit tests * chore: update ds and component dependencies * fix: components build * ✨ feat(FT-1075): search result list item (#5214) The list of search results The footer of the modal window, including the "save" button which applies the changes to the content. If you don't save, you will discard the changes, effectively canceling the change. The sizing of the modal window, including scroll overflow Primitive components for building lists: Divider, List, ListItem, and ListItemButton were added to @storyblok/components. * 🏗️ chore: update MSW to 2.0 (#5271) * chore: update vue version * fix: update vue-i18n mock * chore: update libraries * chore: update msw * fix: unit tests * fix: mock service worker handlers * chore: update unit tests * chore: update ds and component dependencies * fix: unit tests * fix: increase test timing * fix: skip flaky tests * chore: increase bail value * fix: unit tests for content browser * fix: flaky unit test * fix(work-1636): content list - UI aesthetic bug Deploy from source window (#5268) * fix: unit tests * 🐛 fix(FT-1124): search on initial load (#5237) When the advanced search modal is opened, search automatically. This feature was broken because of the folder search that is currently not being used in the advaced search, but was copied from list stories. The folder id to search in was read from the storyId param, but this has a different meaning in ListStories and the Visual Editor. The solution is to simply set this to undefined. We don't delete it entirely, because we might want to implement folder search in the future. * 🐛 fix(FT-1118): remove routing (#5238) Remove routing from the advanced search in the multi-options field type. When you add filters, the query parameters should not be affected. Note that this PR does not address the issue to do with sorting, as this seems to stem from ListStoriesActions, which was not touched by this feature. I will address this in a separate issue, or delegate this to the team responsible for this component: FT-1133 * ✨ feat(FT-1121): empty state in advanced search (#5243) In the options field type > advanced search, adding an empty state visual for when no items were found. * fix: dayjs issue * fix: add vite ignore * fix: skip flaky test * fix: typo * 🐛 fix(FT-1142): saving and deleting preset filters (#5277) Allow users to save and delete presets in the advanced search in the options field type. Also refactored the layout in the ModalStorySearch, so that we're using SbModalFooter and SbModalContent. I wasn't aware that these existed, as they're not documented on blok.ink. * 🐛 fix(INT-1198): wrong links inside App Directory/ App (#5253) * fix(int-1198): adding correct routes to the previous route * fix(int-1198): convert rout params body into a computed * 🐛 fix: use new design tokens (#5293) * fix: use new design tokens * Update src/components/Base/BaseDefineComponentSchema/Schema/Option/StoryOptionStyle/EntryButton.vue * ✨ feat(FT-1131): restrict search results by slug pattern (#5247) For the advanced search feature in the options field type, enable the "Path to folder of stories" feature (the name is misleading, hence the title of this PR is different). Moves the ModalStorySearch from BaseEnhancedSelect to Option field type. It does not belong in the BaseEnhancedSelect component. This means that we need to elevate the state that determines whether the modal is open into the parent components, and accept this value via a prop instead. extract the logic that parses the pattern into a by_slugs filter. This logic does not belong to the body of a component but should be in a separate .ts file, which makes it an excellent target for unit testing. Add a missing property to the options and option schema components: folder_slug Add a new option to useStorySearch that accepts a by_slugs filter. * fix: smooth transition in ListStories and options advanced search (#5274) Transition the filter section smoothly when searching stories: In ListStories In StorySearch, which is used in the advanced search for the options field type. * fix: design system build * 🏗️ chore: regex eslint fixes (#5246) * chore: update eslint nibble fies * chore: run eslint for regex expressions * fix: regex autoformat issues * fix: eslint issues * fix: unit test timing * ✨ feat(FT-1130): restrict content type on options field advanced search (#5272) In the advanced search in the options field type, implement the restrict to content type feature: image When that option has been selected, a filter is mixed in to the filter_query object that is used to fetch the stories. This means that if the user selected a filter in the advanced search, that filter is still used together with the filter from the restrict to content type config as long as that filter is not filtering by content type. In such case, the filter from the advanced search is overridden by the filter that is set in the schema. To indicate that the filter is not being used, I opted to disable the filter in the UI: image Not that: The disabled state is not aligned with the design system It's still possible to add the filter. We could have disabled the content type filter from the list where you add new filters, but it would still be possible to add that kind of filters via presets. More details on 1) below 1. Aligning with design system To make the UI of the disabled filter align with the design system, we'd have to alternative is to Implement disabled state for SbTags SbIconButton a raw input element that is used in one place instead of SbTextField. Alternatively, swap out the input to SbTextField fix a bug in SbTextField where the icon buttons don't get disabled when the text field itself is disabled: https://blok.ink/?path=/story/forms-sbtextfield--with-icon&args=disabled:!true Recursively apply the disabled prop to all child elements. Possibly other things that I haven't discovered yet That is too much work to get this feature out by the end of the month. * ✨ feat(FT-1119): story status icon (#5257) In the advanced search in the options field type, add the story status icon to the the search results: image Refactored BaseStoryStatus to composition API Needed to remove the gap on ListItem and ListItemButton. It wasn't supposed to be there to begin with. The alignment of the checkbox label is a bit wrong still, but this is due to what I perceive as a bug in SbCheckbox (FT-1138) * 🐛 fix(ON-1739): get org spaces from other regions to list spaces that the user is active (#5282) * fix(on-1739): group all org space regions * refactor(on-1739): use constants * fix(on-1739): loading of user active spaces * feat(on-1739): group org spaces from other regions to list as active spaces * refactor(on-1739): rename components * fix(on-1739): fix unit test * fix: import of file on unit test * refactor(on-1739): add multiple missing types * chore: update files * refactor(on-1739): remove unused import of org * chore: apply PR suggestions --------- Co-authored-by: ECJ222 <[email protected]> * ✨ feat(FT-1120): open story new tab link (#5298) * feat(FT-1120): open story new tab link * fix(FT-1120): add border to the link * fix(FT-1120): add hover effect * fix(FT-1120): github action review * refactor(ft-1120): change order of properties and the use of base-border variable --------- Co-authored-by: Emanuel Gonçalves <[email protected]> * ♻️ refactor(FT-1158): extract the StoryCard component to the src/components/Base folder (#5302) * refactor(ft-1158): move the StoryCard to src/components/Base folder * fix(ft-1158): fix reference to the story when try to open it * fix(ft-1158): fix remove item logic for stories source * refactor(ft-1158): add TS type to control which type the EnhancedSelect accepts * refactor(ft-1158): remove spacing * 🐛 fix(AR-245): add aria label to sb icon button (#5278) * fix(ar-245): add aria label to sb icon button * Update src/components/ContentManager/ListAssets/components/AssetsUploadModal/AssetUploadItem.vue Co-authored-by: Lisi Linhart <[email protected]> * fix(ar-245): fix localization and spelling * Update packages/design-system/src/components/IconButton/SbIconButton.vue Co-authored-by: Johannes Lindgren <[email protected]> * Update packages/design-system/src/components/IconButton/SbIconButton.vue Co-authored-by: Johannes Lindgren <[email protected]> * fix(AR-245): add more descriptive label and refactor template structure * Update src/components/ContentManager/EditorPage/EditorForm/EditorFormHeader/EditorFormHeaderTitle.vue Co-authored-by: Lorena Ramonda <[email protected]> * fix(AR-245): fix wording * fix: delete old file * fix: story syntax --------- Co-authored-by: Lisi Linhart <[email protected]> Co-authored-by: Johannes Lindgren <[email protected]> Co-authored-by: Lorena Ramonda <[email protected]> * ✨ feat(FT-1099): add modal header (#5286) * feat(FT-1099): add modal header * fix(FT-1099): css attributes order * fix(FT-1099): resolve merge conflict * refactor(FT-1099): update css location * chore: update design system * ♻️ refactor(FT-1137): sb-separator (#5251) * refactor: SbSeparator * refactor: rename type alias * fix: margin in VisualEditor settings * fix: design system unit tests * ✨ feat(FT-1084): update the styles in the StoryCard and allow the preview card (#5204) * feat(ft-1083): implement config for preview_card_image field * feat(ft-1083): implement the advanced search parameter in the config * feat(ft-1083): implement logic to select the entry story appearance * feat(ft-1083): add types for the new fields in the multi-options field type * fix(ft-1083): fix vue-tsc error * feat(ft-1083): add the missing SVGs and update the card styles * fix(ft-1083): adjust styles in the multi options field config * fix(ft-1083): make some updates from the code review * refactor(ft-1083): refactor the StoryOptionsStyle component splitting it into small components * feat(ft-1084): implement styles to have the story card with an image * refactor(ft-1084): implement some changes in the style for fieldtype multi-options * fix(ft-1084): fix group actions positioning * refactor(ft-1084): add support to the content_type_asset_preview key in component model * fix(ft-1084): fix issue about the condition to show the asset preview * fix(ft-1084): fix code based on code reviews and change some hover styles * refactor(ft-1084): add missing code after sync with release and add code review requests * refactor(ft-1084): implement code review request changes * fix(ft-1084): implement some changes in the code related to the code review * fix(ft-1084): fix is_private condition in the isAssetContentRecord function * fix(ft-1084): add with_summary parameter when loading missing stories --------- Co-authored-by: sandrodarrieux <[email protected]> * fix: cypress settings * test: fix failing tests (#5313) * fix(FT-1133): make sort by not persist and disable routing (#5309) Co-authored-by: Johannes Lindgren <[email protected]> * 🐛 fix(FT-1165): advanced search settings label (#5314) * fix: change enable advanced search label * fix: change enable advanced search label * ✨ feat(AR-268): add old rendering service settings for v1 sunset (#5311) * feat: add old renderer * fix: type export * fix: seperator spacing * fix: code review comments * ✨ feat(ON-1732): refactors SignUpForm using Composition API & TS + adds missing GCLID query param (#5312) * refactor(ON-1732): refactors component using Composition API & TS * feat(ON-1732): adds gclid query param to onboarding form * feat(ON-1732): fix vue-tsc error * feat(ON-1732): fixes unit test * fix: cypress settings * ✨ feat(FT-1097): infinite scroll in options field type advanced search (#5288) * feat(ft-1083): implement config for preview_card_image field * feat(ft-1083): implement the advanced search parameter in the config * feat(ft-1083): implement logic to select the entry story appearance * feat(ft-1083): add types for the new fields in the multi-options field type * fix(ft-1083): fix vue-tsc error * feat(ft-1083): add the missing SVGs and update the card styles * fix(ft-1083): adjust styles in the multi options field config * fix(ft-1083): make some updates from the code review * refactor(ft-1083): refactor the StoryOptionsStyle component splitting it into small components * fix(ft-1083): update styles for the buttons in StoryOptionStyle component * fix(ft-1083): fix active text color style * feat(ft-1083): adding the tooltip in appearance label * feat: advanced search modal * feat: advanced search modal * fix: ts error * fix: TODO comments * fix: undo types * fix: ts error * fix: ts error * Apply suggestions from code review * fix: ts error * chore(FT-1075): make design system work with workspaces * feat(FT-1058): search result list item * fix: remove yarn lock file * feat: list for search results * fix: storybook * fix: keyboard nav * fix: selected style * fix: remove Avatar.vue * fix: remove Avatar.vue * fix: remove CopuButtonDemo.vue * Apply suggestions from code review * fix: add security to sidebar * fix: delay in click on tag, force user to save * feat: Divider component * feat: Divider component * fix: import * fix: modal width * fix: rename List and Divider to multi-word * fix: remove breadcrumbs * feat: add flag for only searching folders to useStorySearch.ts * feat(ft-1083): implement logic to select the entry story appearance * feat(ft-1083): add the missing SVGs and update the card styles * fix(ft-1083): adjust styles in the multi options field config * fix(ft-1083): make some updates from the code review * refactor(ft-1083): refactor the StoryOptionsStyle component splitting it into small components * feat: advanced search modal * fix: ts error * fix: TODO comments * fix: ts error * chore(FT-1075): make design system work with workspaces * feat(FT-1058): search result list item * feat: list for search results * fix: storybook * fix: keyboard nav * fix: selected style * fix: remove Avatar.vue * fix: remove Avatar.vue * fix: remove CopuButtonDemo.vue * Apply suggestions from code review * fix: add security to sidebar * fix: delay in click on tag, force user to save * feat: Divider component * feat: Divider component * fix: import * fix: modal width * fix: rename List and Divider to multi-word * fix: remove breadcrumbs * feat: add flag for only searching folders to useStorySearch.ts * fix: update `@storyblok/components` to new palette * fix: update yarn lock * Update package.json * fix: update yarn lock * fix: update sass variable after change of palette * fix: search on initial load * fix: remove routing * fix: wip * feat: skeletons * feat: empty state * feat: restrict search results by slug pattern * fix: handle empty strings as absence of query * fix: use american spelling * fix: type errors * refactor: simply expression * Update src/components/ContentManager/EditorPage/EditorForm/FieldTypeOption/index.vue * Update src/components/ContentManager/EditorPage/EditorForm/FieldTypeOption/index.vue * feat: filter by content type * feat: disable filter if overridden by field schema * fix: spelling * feat: infinite scroll * fix: remove DividerLine * fix: renamed prop * fix: allow changing query * fix: scroll to top * fix: blank space in package.json * fix: remove console.log * refactor: renaming * fix: gap * fix: type errors * fix: type error --------- Co-authored-by: Emanuel Gonçalves <[email protected]> Co-authored-by: sandrodarrieux <[email protected]> * ✨ feat(FT-1052): implement the References field type as options type (#5235) * feat(ft-1052): add logic in Block Library to handle with the new options type called references * fix(ft-1052): update logic to check if the preview field type was a references option * fix(ft-1052): delete the source if the new fieldtype is not an option field * test(ft-1052): implement more unit tests to cover the references options field type * fix(ft-1052): fix scss variables in EntryButton component * refactor(ft-1052): refactor code related to code review * fix(ft-1052): compute the references fields and before saving replace the references type to options * fix(ft-1052): fix some TS errors * fix(ft-1052): fix unit tests * fix(ft-1052): clean references parameters and update unit tests * fix(ft-1052): handle the type when the user tries to edit directly from the editor * fix(ft-1052): pass the correct field type value when editing the field --------- Co-authored-by: sandrodarrieux <[email protected]> * ♻️ refactor: all design system stories to typescript vue 3 and new storybook syntax (#5301) * ✨ feat(ar-265): allow space creation in other regions for everyone (not just org) (#5299) --------- Co-authored-by: Ademar Cardoso <[email protected]> * ✨ feat(FT-1144): image preview in advanced search results (#5320) Enable the preview image in the advanced search results in the options field type (when enabled): image Update hover/focus/select colors, so that the background image looks better. Also becomes consistent with ListStories. The drawback is that you won't be able to differentiate between focus and selected states anymore, thus decreasing accessibility. Moved StorySearch and ModalStorySearch to FieldTypeOptions module. It used to be part of BaseEnchanchedSelect, but this was changed a few PRs ago. Extracted SearchResultItem from StorySearch. Extracted Thumbnail from BaseStoryCard into @storyblok/components, since we need it in SearchResultItem. Extracted previewImageFromContentSummary from BaseStoryCard into types/components, since we need it in SearchResultItem. * 🧪 test: str 2177 server test assets e2e (#5259) * test: str:2177 * test: used POM * test: add space id * test: commit custom url * test: added param * test: add url * fix: url name * test: changed path * test: move intercept --------- Co-authored-by: Dhiego Bastos <[email protected]> Co-authored-by: Lisi Linhart <[email protected]> * chore: fix separator issues * chore: update design-system package.json and yarn.lock * fix: increase test timing * fix: increase test timing * fix(FT-1105): add sbNotify to useStorySearch (#5318) Co-authored-by: sandrodarrieux <[email protected]> * style(work-1680): fix stticky content list on mobile version (#5330) * fix: increase test timing * chore: update docs * 🐛 fix(FT-1162): advanced search responsiveness (#5327) Adapt the advanced search to small screens: Show filters on small screens. Before, they did not show on small screens. Make filters scrollable. You could potentially have many filters, and especially on small devices, the filters are blocking the search results. Therefore, include the filters in the vertical scroll. 2024-02-29_17-02-09 (1) When the story name and/or slug is long, overflow with ellipses, instead of wrapping with line breaks: image Note that the modal still had too much margin and padding on mobiles, but this is an issue in the design system. Miscellaneous fixes: Added padding to the "keep typing to search..." text Added a missing CSS attribute to on ListItemButton which prevents the content from overflowing: box-sizing: border-box; width: 100%; Use the new SbSeparator component * fix: base country selector separator (#5325) * 🐛 fix(FT-1157): allow filter dropdown on smaller screens (#5300) Allow the filter modal to be displayed on smaller screens * fix: skip flaky test * fix: skip flaky tests * fix: display settings option in space card * fix(str-2150): fix pagination issue on deleted assets page (#5329) * 🐛 fix: unnecessary routing to enterprise form (#5335) * fix: unnecessary routing to enterprise form * fix: add pr suggestion * fix: various fixes (#5333) * 🐛 fix: reset user collaborator tab back to default when all invited users has been removed (#5324) * fix: change invited tab to active tab when all invited users has been removed * chore: reload space after removing an invited collaborator * fix: apply pr suggestion * fix: missing seperators * 🧪 test(work-1678): e2e servers improvement (#5328) * test(work-1678): e2e servers improvement * test(work-1678): fix commands.js conflicts * fix: text for Nikola * chore: skip flaky test * chore: update action * 🧪 test: render advanced search modal conditionally (#5340) * test: render advanced search modal conditionally * test: fix LanguageSelector * chore: update sonar property action * chore: update sonar property action * 🧪 test(shape-2302): fix test code in fieldtype tests (#5345) * test(shape-2302): fix test code in fieldtype tests * Add time for FieldTypeGroup.ci.specs.js --------- Co-authored-by: Dhiego Bastos <[email protected]> * fix: error notifications in useStorySearch.ts (#5338) * 🐛 fix(FT-1175): thumbnail for non-images in options field type (#5380) When an options field type has source set to story and the appearance is set to "entry card", display a thumbnail not only for images, but also for auto files, videos, and other files—just like the asset library does: Advanced search: image To achieve this, I changed the Thumbnail component to be a ThumbnailContainer. Instead of passing a src string prop that is rendered as an img element, we pass a node via slots that are then fitted to a specific size. We pass an AssetsListItemThumb element, which is used in the assets field type. In this way, we can display a thumbnail for videos, audio files, and other file types. I also had to parameterize the icon size in the video components. Before, there was no way to control this from the outside unless you queries the internal elements. Now, we can pass props to control the icon sizes. * fix: popover for options filter is hidden (#5399) * fix: fix some tsc errors * fix: fix unit tests and change the asset content to check the correct boolean value when string --------- Co-authored-by: Lisi Linhart <[email protected]> Co-authored-by: Enoch Chejieh <[email protected]> Co-authored-by: Carolina Faria <[email protected]> Co-authored-by: Johannes Lindgren <[email protected]> Co-authored-by: sandrodarrieux <[email protected]> Co-authored-by: Gustavo Melki Portaluri <[email protected]> Co-authored-by: Thomas Sweet <[email protected]> Co-authored-by: marcos henrique pereira ramos <[email protected]> Co-authored-by: Dhiego Bastos <[email protected]> Co-authored-by: Fernanda do Canto Nogueira <[email protected]> Co-authored-by: Adel <[email protected]> Co-authored-by: Codequeen <[email protected]> Co-authored-by: marisbbr <[email protected]> Co-authored-by: Eunjae Lee <[email protected]> Co-authored-by: Ademar Cardoso <[email protected]> Co-authored-by: Silas Getachew <[email protected]> Co-authored-by: Josefine Schaefer <[email protected]> Co-authored-by: Lorena Ramonda <[email protected]>
|
The latest updates on your projects. Learn more about Vercel for Git ↗︎
|
|
🎉 This PR is included in version 3.25.1 🎉 The release is available on: Your semantic-release bot 📦🚀 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Pull request type
Jira Link: SHAPE-2441
How to test this PR
In the visual editor, go to a story without any discussions and check if the icon size of the empty state is correct.
Obs., this PR contains code from other PR's merged to develop without being deployed to production.