Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

types: use WebRenderer type as new Addon_BaseAnnotations template variable #106

Merged
merged 3 commits into from
Jun 9, 2023

Conversation

specialdoom
Copy link
Contributor

@specialdoom specialdoom commented Jun 2, 2023

Fixes #105

See @storybook repository PR: here.

Here I'm using the new template variable for the Addon_BaseAnnotations alias BaseAnnotations using the WebRenderer type to have a known type for the canvasElement.

This is a preliminary PR since the version 7.1.0 it's not released yet.

Let me know about anything I have missed.

@socket-security
Copy link

socket-security bot commented Jun 2, 2023

👍 Dependency issues cleared. Learn more about Socket for GitHub ↗︎

This PR previously contained dependency changes with security issues that have been resolved, removed, or ignored.

Next steps

Take a deeper look at the dependency

Take a moment to review the security alert above. Review the linked package source code to understand the potential risk. Ensure the package is not malicious before proceeding. If you're unsure how to proceed, reach out to your security team or ask the Socket team for help at support [AT] socket [DOT] dev.

Remove the package

If you happen to install a dependency that Socket reports as Known Malware you should immediately remove it and select a different dependency. For other alert types, you may may wish to investigate alternative packages or consider if there are other ways to mitigate the specific risk posed by the dependency.

Mark a package as acceptable risk

To ignore an alert, reply with a comment starting with @SocketSecurity ignore followed by a space separated list of package-name@version specifiers. e.g. @SocketSecurity ignore [email protected] bar@* or ignore all packages with @SocketSecurity ignore-all

@JReinhold
Copy link
Collaborator

JReinhold commented Jun 5, 2023

Thanks @specialdoom!
Looks like your PR to core is being patched back to 7.0, so it should be released in 7.0.19 in the coming weeks.

@JReinhold
Copy link
Collaborator

JReinhold commented Jun 6, 2023

The content of this PR looks good, we just need to wait for 7.0.19 to be released, and change the dependency of @storybook/types to "^7.0.0-beta.0 || ^7.0.0-rc.0 || ^7.0.0", then this is good to go. 👍

@specialdoom
Copy link
Contributor Author

specialdoom commented Jun 8, 2023

@JReinhold updated it!

@JReinhold JReinhold merged commit aef414b into storybookjs:main Jun 9, 2023
@shilman
Copy link
Member

shilman commented Jun 9, 2023

🚀 PR was released in v3.0.3 🚀

@shilman shilman added the released This issue/pull request has been released. label Jun 9, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
released This issue/pull request has been released.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

[Bug] CanvasElement unknown type
3 participants