Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update pnpm to v9 & improve CI #180

Merged
merged 9 commits into from
May 15, 2024
Merged

Update pnpm to v9 & improve CI #180

merged 9 commits into from
May 15, 2024

Conversation

xeho91
Copy link
Collaborator

@xeho91 xeho91 commented May 14, 2024

Following the request: #179 (review)

Additional context

  • Added .nvmrc (I've used version that matched the previous CI workflows setup - 20), so my machine can
    automatically set up the right version.
  • Upgraded CI workflows actions, and reduced one action - pnpm/action-setup - in favor of corepack
📦 Published PR as canary version: 4.1.3--canary.180.930cbf4.0

✨ Test out this PR locally via:

npm install @storybook/[email protected]
# or 
yarn add @storybook/[email protected]

@xeho91 xeho91 added skip-release Preserve the current version when merged dependencies Update one or more dependencies version labels May 14, 2024
@xeho91 xeho91 requested a review from JReinhold May 14, 2024 04:34
@xeho91
Copy link
Collaborator Author

xeho91 commented May 14, 2024

@JReinhold I'm puzzled how the Chromatic workflow was able to run successfully before, without the building step 🤔 👀

Copy link
Collaborator

@JReinhold JReinhold left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Great! Only one question

.github/workflows/chromatic.yml Show resolved Hide resolved
@xeho91 xeho91 removed the skip-release Preserve the current version when merged label May 14, 2024
@xeho91 xeho91 added the skip-release Preserve the current version when merged label May 14, 2024
@JReinhold JReinhold merged commit 400f257 into main May 15, 2024
4 checks passed
@shilman
Copy link
Member

shilman commented May 16, 2024

🚀 PR was released in v4.1.3 🚀

@shilman shilman added the released This issue/pull request has been released. label May 16, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
dependencies Update one or more dependencies version released This issue/pull request has been released. skip-release Preserve the current version when merged
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants