Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Make svelte-loader optional #62

Merged
merged 1 commit into from
Jul 7, 2022
Merged

Make svelte-loader optional #62

merged 1 commit into from
Jul 7, 2022

Conversation

benmccann
Copy link
Contributor

@benmccann benmccann commented Jul 6, 2022

Closes #60

It would be nice not to require svelte-loader (webpack support) for Vite projects. You need either it or @storybook/builder-vite, but it doesn't matter which one

I'm also removing svelte as optional as it seems like something you kind of need in a Svelte project though I don't really have strong feelings in whether it's listed as optional or not

Companion PR in storybookjs/storybook#18645

Copy link
Member

@IanVS IanVS left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Makes sense to me, but it would be great to get @j3rem1e's opinion.

@j3rem1e
Copy link
Contributor

j3rem1e commented Jul 7, 2022

I am ok with this change.

@IanVS IanVS merged commit be3cfee into storybookjs:main Jul 7, 2022
@shilman
Copy link
Member

shilman commented Jul 7, 2022

🚀 PR was released in v2.0.5 🚀

@shilman shilman added the released This issue/pull request has been released. label Jul 7, 2022
@benmccann benmccann deleted the patch-2 branch July 7, 2022 21:28
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
released This issue/pull request has been released.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

[Bug] replace svelte-loader
4 participants