Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: v5 notes addon crash and fail to install #362

Merged
merged 7 commits into from
Jul 14, 2022
Merged

Conversation

dannyhw
Copy link
Member

@dannyhw dannyhw commented Jun 25, 2022

Issue: #46

There were lots of issues when I tried to make a build with the notes addon bug and I attempted to resolve some of them here.

Will make a release soon.

@dannyhw dannyhw self-assigned this Jun 25, 2022
@AlexanderEggers
Copy link

@dannyhw When do you plan to merge this PR? I was thinking of contribute some work to the project but there is probably not much a point unless this one is merged and somewhat stable.

@dannyhw
Copy link
Member Author

dannyhw commented Jul 13, 2022

@AlexanderEggers

I've been away recently so haven't had time, sorry for the wait.

the fix is ready but i had trouble on the master branch getting the ci to pass. Generally I've been putting fixes on the next (beta) branch so I haven't done any builds on master for a while. If its an option I'd say disable the notes addon for now if you need to get past the error.

I will try to do a pre-release with the fix tomorrow if I can and once I confirm it's working I'll make a new stable version.

@dannyhw
Copy link
Member Author

dannyhw commented Jul 13, 2022

Seems like linting is just failing because a package needs to be added, these changes are from the react native upgrade.

@dannyhw
Copy link
Member Author

dannyhw commented Jul 14, 2022

now testable on

@dannyhw
Copy link
Member Author

dannyhw commented Jul 14, 2022

linting is failing but its not a big deal since the linting was reworked for the next-6.0 branch

@dannyhw dannyhw merged commit 8278a84 into master Jul 14, 2022
@dannyhw dannyhw deleted the fix/v5-markdown branch February 2, 2024 18:10
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants