fix: make react hooks useable in component story #379
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
@zhouzh1 hey sorry I missed this, seems good to me 👍. I'll just give it a run to make sure but I don't see why it wouldn't work. |
|
Hi, @dannyhw, I think it is due to the rendering mechanism inside React, even though a React component is essentially just a function, we still need to let React know that the function is a component, otherwise it will be treated as just a function, or just a part of the hosted component, then the hooks used in the function cause this kind of issue. :) |
|
@zhouzh1 thanks for the extra info, that's good to know. Although I was referring to your fix seeming like it was fine and I wouldn't find any issue :) anyway this is live now in the 6.0.1-beta.8 release |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Issue: N/A
What I did
When I added the
useEffectand other react hooks in component stories, I encountered theReact has detected a change in the order of Hookserror, after a investigation, found that the story preview content is got by the method of calling the story function, maybe we need to change it to render the story component. :)How to test
Please explain how to test your changes and consider the following questions
If your answer is yes to any of these, please make sure to include it in your PR.