Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix(): update react-native-modal-selector to new version #74

Merged
merged 5 commits into from
Aug 6, 2020
Merged

fix(): update react-native-modal-selector to new version #74

merged 5 commits into from
Aug 6, 2020

Conversation

jon-moreira
Copy link
Contributor

Issue:

What I did

Just update the external dependency react-native-modal-selector inside of ondevice-knobs addons to prevent error bellow
Image from iOS

How to test

  • Is this testable with Jest or Chromatic screenshots? no
  • Does this need a new example in the kitchen sink apps? no
  • Does this need an update to the documentation? no

@dannyhw dannyhw self-assigned this Aug 4, 2020
@dannyhw dannyhw merged commit 22e49b4 into storybookjs:master Aug 6, 2020
@dannyhw dannyhw mentioned this pull request Aug 11, 2020
Closed
@dannyhw
Copy link
Member

dannyhw commented Aug 11, 2020

fixes #62

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@Gongreg Gongreg Awaiting requested review from Gongreg

@ndelangen ndelangen Awaiting requested review from ndelangen

@shilman shilman Awaiting requested review from shilman

Assignees

@dannyhw dannyhw

Labels
addon: knobs dependencies:update has workaround
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@jon-moreira @dannyhw