Skip to content

Commit

Permalink
Merge pull request #19870 from storybookjs/fix/replace-degit-with-gegit
Browse files Browse the repository at this point in the history
CLI: Replace degit with giget
  • Loading branch information
shilman authored Nov 19, 2022
2 parents 214ed3f + a9a5524 commit d49761b
Show file tree
Hide file tree
Showing 6 changed files with 48 additions and 27 deletions.
3 changes: 1 addition & 2 deletions code/lib/cli/package.json
Original file line number Diff line number Diff line change
Expand Up @@ -55,14 +55,14 @@
"chalk": "^4.1.0",
"commander": "^6.2.1",
"cross-spawn": "^7.0.3",
"degit": "^2.8.4",
"detect-indent": "^6.1.0",
"envinfo": "^7.7.3",
"execa": "^5.0.0",
"express": "^4.17.1",
"find-up": "^5.0.0",
"fs-extra": "^9.0.1",
"get-port": "^5.1.1",
"giget": "^1.0.0",
"globby": "^11.0.2",
"jscodeshift": "^0.13.1",
"leven": "^3.1.0",
Expand All @@ -79,7 +79,6 @@
"devDependencies": {
"@storybook/client-api": "7.0.0-alpha.50",
"@types/cross-spawn": "^6.0.2",
"@types/degit": "^2.8.3",
"@types/prompts": "^2.0.9",
"@types/puppeteer-core": "^2.1.0",
"@types/semver": "^7.3.4",
Expand Down
2 changes: 1 addition & 1 deletion code/lib/cli/src/generate.ts
Original file line number Diff line number Diff line change
Expand Up @@ -161,7 +161,7 @@ program
.command('repro-next [filterValue]')
.description('Create a reproduction from a set of possible templates')
.option('-o --output <outDir>', 'Define an output directory')
.option('-b --branch <branch>', 'Define the branch to degit from', 'next')
.option('-b --branch <branch>', 'Define the branch to download from', 'next')
.option('--no-init', 'Whether to download a template without an initialized Storybook', false)
.action((filterValue, options) =>
reproNext({ filterValue, ...options }).catch((e) => {
Expand Down
2 changes: 1 addition & 1 deletion code/lib/cli/src/repro-generators/configs.ts
Original file line number Diff line number Diff line change
Expand Up @@ -264,5 +264,5 @@ export const svelte: Parameters = {
renderer: 'svelte',
name: 'svelte',
version: 'latest',
generator: 'npx degit sveltejs/template {{appName}}',
generator: 'npx giget github:sveltejs/template#master {{appName}}',
};
9 changes: 5 additions & 4 deletions code/lib/cli/src/repro-next.ts
Original file line number Diff line number Diff line change
Expand Up @@ -3,7 +3,7 @@ import path from 'path';
import chalk from 'chalk';
import boxen from 'boxen';
import { dedent } from 'ts-dedent';
import degit from 'degit';
import { downloadTemplate } from 'giget';

import { existsSync } from 'fs-extra';
import { allTemplates as TEMPLATES } from './repro-templates';
Expand Down Expand Up @@ -137,12 +137,13 @@ export const reproNext = async ({
try {
const templateType = init ? 'after-storybook' : 'before-storybook';
// Download the repro based on subfolder "after-storybook" and selected branch
await degit(
`storybookjs/repro-templates-temp/${selectedTemplate}/${templateType}#${branch}`,
await downloadTemplate(
`github:storybookjs/repro-templates-temp/${selectedTemplate}/${templateType}#${branch}`,
{
force: true,
dir: templateDestination,
}
).clone(templateDestination);
);
} catch (err) {
logger.error(`🚨 Failed to download repro template: ${err.message}`);
throw err;
Expand Down
57 changes: 39 additions & 18 deletions code/yarn.lock
Original file line number Diff line number Diff line change
Expand Up @@ -6007,7 +6007,6 @@ __metadata:
"@storybook/telemetry": 7.0.0-alpha.50
"@storybook/types": 7.0.0-alpha.50
"@types/cross-spawn": ^6.0.2
"@types/degit": ^2.8.3
"@types/prompts": ^2.0.9
"@types/puppeteer-core": ^2.1.0
"@types/semver": ^7.3.4
Expand All @@ -6018,14 +6017,14 @@ __metadata:
chalk: ^4.1.0
commander: ^6.2.1
cross-spawn: ^7.0.3
degit: ^2.8.4
detect-indent: ^6.1.0
envinfo: ^7.7.3
execa: ^5.0.0
express: ^4.17.1
find-up: ^5.0.0
fs-extra: ^9.0.1
get-port: ^5.1.1
giget: ^1.0.0
globby: ^11.0.2
jscodeshift: ^0.13.1
leven: ^3.1.0
Expand Down Expand Up @@ -8114,13 +8113,6 @@ __metadata:
languageName: node
linkType: hard

"@types/degit@npm:^2.8.3":
version: 2.8.3
resolution: "@types/degit@npm:2.8.3"
checksum: 1693dc0033aa5aa5c339b76d570c462e3e0ff41e22a7cc2d0164276199ddbd6ed18813042868355bc5f60ee257c0b18bce904c193008685b790392454ec9fcbd
languageName: node
linkType: hard

"@types/detect-port@npm:^1.3.2":
version: 1.3.2
resolution: "@types/detect-port@npm:1.3.2"
Expand Down Expand Up @@ -12825,7 +12817,7 @@ __metadata:
languageName: node
linkType: hard

"colorette@npm:^2.0.10, colorette@npm:^2.0.16":
"colorette@npm:^2.0.10, colorette@npm:^2.0.16, colorette@npm:^2.0.19":
version: 2.0.19
resolution: "colorette@npm:2.0.19"
checksum: 2bcc9134095750fece6e88167011499b964b78bf0ea953469130ddb1dba3c8fe6c03debb0ae181e710e2be10900d117460f980483a7df4ba4a1bac3b182ecb64
Expand Down Expand Up @@ -14170,12 +14162,10 @@ __metadata:
languageName: node
linkType: hard

"degit@npm:^2.8.4":
version: 2.8.4
resolution: "degit@npm:2.8.4"
bin:
degit: degit
checksum: 25ae9daf8010b450ffe8307c5ca903fe8bfaa8bb8622da12f81f2b6c3b1bb24e96fe3ab0b4ec4a1a19684f674b2158a8a3a2178c481882cc4991c7a0859ec40a
"defu@npm:^6.1.1":
version: 6.1.1
resolution: "defu@npm:6.1.1"
checksum: ee442ce5289b3060a6cef85fdf6a29dbf2b9b6c39ac30a6ee5c8885671cd34214aae2ebb131fb071454122d3a3ce6d304931f53a732d98938ef396e12c04aa71
languageName: node
linkType: hard

Expand Down Expand Up @@ -17975,6 +17965,23 @@ __metadata:
languageName: node
linkType: hard

"giget@npm:^1.0.0":
version: 1.0.0
resolution: "giget@npm:1.0.0"
dependencies:
colorette: ^2.0.19
defu: ^6.1.1
https-proxy-agent: ^5.0.1
mri: ^1.2.0
node-fetch-native: ^1.0.1
pathe: ^1.0.0
tar: ^6.1.12
bin:
giget: dist/cli.mjs
checksum: cacc0b531356bb8e494742856ee4df39bd90a1a733122e79606b0d4d1b7489532133fed7f92ccb6334478e66079534ef52e3c932e5d695a032b61b4e48c749b6
languageName: node
linkType: hard

"git-config-path@npm:^1.0.1":
version: 1.0.1
resolution: "git-config-path@npm:1.0.1"
Expand Down Expand Up @@ -24606,7 +24613,7 @@ __metadata:
languageName: node
linkType: hard

"mri@npm:^1.1.0":
"mri@npm:^1.1.0, mri@npm:^1.2.0":
version: 1.2.0
resolution: "mri@npm:1.2.0"
checksum: a3d32379c2554cf7351db6237ddc18dc9e54e4214953f3da105b97dc3babe0deb3ffe99cf409b38ea47cc29f9430561ba6b53b24ab8f9ce97a4b50409e4a50e7
Expand Down Expand Up @@ -24969,6 +24976,13 @@ __metadata:
languageName: node
linkType: hard

"node-fetch-native@npm:^1.0.1":
version: 1.0.1
resolution: "node-fetch-native@npm:1.0.1"
checksum: 27841116388ea5309037400de7fa1003712e974dc57a048f78e5fc659fa80095403f34051c069096a9bd705c7445876d88624121365847f617520325693d67c8
languageName: node
linkType: hard

"node-fetch-npm@npm:^2.0.2":
version: 2.0.4
resolution: "node-fetch-npm@npm:2.0.4"
Expand Down Expand Up @@ -26417,6 +26431,13 @@ __metadata:
languageName: node
linkType: hard

"pathe@npm:^1.0.0":
version: 1.0.0
resolution: "pathe@npm:1.0.0"
checksum: ac075cc2cf401733e84b755920291614fb23f2b022a6c617b62f370f981980d3d2f73e5de51fb7363339ab769d35c80d3d20ae9c999e9d0b3b0c143b067f60cf
languageName: node
linkType: hard

"pause-stream@npm:0.0.11, pause-stream@npm:^0.0.11":
version: 0.0.11
resolution: "pause-stream@npm:0.0.11"
Expand Down Expand Up @@ -31972,7 +31993,7 @@ __metadata:
languageName: node
linkType: hard

"tar@npm:^6.0.2, tar@npm:^6.1.0, tar@npm:^6.1.11, tar@npm:^6.1.2":
"tar@npm:^6.0.2, tar@npm:^6.1.0, tar@npm:^6.1.11, tar@npm:^6.1.12, tar@npm:^6.1.2":
version: 6.1.12
resolution: "tar@npm:6.1.12"
dependencies:
Expand Down
2 changes: 1 addition & 1 deletion scripts/task.ts
Original file line number Diff line number Diff line change
Expand Up @@ -145,7 +145,7 @@ export const options = createOptions({
},
fromLocalRepro: {
type: 'boolean',
description: 'Create the template from a local repro (rather than degitting it)?',
description: 'Create the template from a local repro (rather than downloading it)?',
promptType: false,
},
dryRun: {
Expand Down

0 comments on commit d49761b

Please sign in to comment.