Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[Bug]: Visual Test addon does not show test/filter buttons in 8.0-alpha #25404

Closed
2 tasks
shilman opened this issue Jan 2, 2024 · 0 comments · Fixed by #25426
Closed
2 tasks

[Bug]: Visual Test addon does not show test/filter buttons in 8.0-alpha #25404

shilman opened this issue Jan 2, 2024 · 0 comments · Fixed by #25426
Assignees
@ndelangen
Labels
api: addons bug sev:S2 ui

Comments

@shilman
Copy link
Member

shilman commented Jan 2, 2024 •
edited
Loading

Describe the bug

In the monorepo, run yarn storybook:ui. The visual test addon is missing its test and filter buttons from the sidebar.

Removing useMemo from these lines fixes it, but it might not be the right fix:

https://github.com/storybookjs/storybook/blob/next/code/ui/manager/src/container/Sidebar.tsx#L45-L46

Need:

  • A proper fix
  • Tests to ensure it does not regress

To Reproduce

No response

System

No response

Additional context

No response
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@ndelangen ndelangen

Labels
api: addons bug sev:S2 ui
Projects
Core Team Projects
Archived in project
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

UI: Fix sidebar top and bottom addon slots storybookjs/storybook
2 participants
@shilman @ndelangen