[Bug]: Resizing of Storybook Panel doesn't always apply #25759
Labels
Comments
vanessayuenn
changed the title
|
Hi! Could I try and take this on? |
|
@brielle5810 of course! PR is very welcome! If this is your first contribution, be sure to check the contribution guide and hop onto the Storybook Discord if you need any help getting started. Looking forward to your contribution! ✨ |
jorge-ji
added a commit
to jorge-ji/storybook
that referenced
this issue
Mar 12, 2024
When trying to resize any panel too fast, the changes would not be applied.
The fix was done by changing a comparison condition in "useLayoutEffect()". Instead of using a variable ("prevManagerLayoutStateRef") that was also modified by another function ("useEffect()") that could execute at the same time, it now uses a variable that is only modified by the own function, making it so that the supposed layout values are not changed after they are set.
8 tasks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Describe the bug
Project: Bitwarden (Angular)
Version: 8.0.0-alpha.13
Bug/feedback: Resizing of Storybook Panel doesn't always apply
Tested Browser: Edge (but also encountered it in Chrome a while ago)
When the panel is resized fast, the changes aren't always applied:
Aufzeichnung.2024-01-23.153723.mp4
To Reproduce
PrimaryButton Story.System
No response
Additional context
No response
The text was updated successfully, but these errors were encountered: