Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Readme Images on NPM broken across the board #6556

Closed
kevbost opened this issue Apr 17, 2019 · 0 comments · Fixed by #6672
Closed

Readme Images on NPM broken across the board #6556

kevbost opened this issue Apr 17, 2019 · 0 comments · Fixed by #6672
Labels
bug documentation good first issue
Milestone
5.0.x

Comments

@kevbost
Copy link

kevbost commented Apr 17, 2019

Describe the bug
README images are broken across the board.
(see #1196)

To Reproduce
Steps to reproduce the behavior:

  1. Go to https://www.npmjs.com/package/@storybook/addon-actions
  2. Go to https://www.npmjs.com/package/@storybook/addon-storyshots

image

Additional context
There's a difference in the source paths between images that resolve and images that don't resolve. I'm not fluent on how github.com/path/image.png becomes raw.githubusercontent.com/path/image.png, it may just be pending a publish -- i dont know.

Regardless, it makes everything feel broken.

Image path from npm's addon-actions (as example):
https://raw.githubusercontent.com/storybooks/storybook/HEAD/docs/screenshot.png

Manually altered path:
https://raw.githubusercontent.com/storybooks/storybook/HEAD/addons/actions/docs/screenshot.png
@shilman shilman added this to the 5.0.x milestone Apr 18, 2019
rajatrao777 added a commit to rajatrao777/storybook that referenced this issue Apr 29, 2019
@rajatrao777
updated npm broken link issue storybookjs#6556
3c54b1e
rajatrao777 added a commit to rajatrao777/storybook that referenced this issue Apr 29, 2019
@rajatrao777
updated npm broken link issue storybookjs#6556
9aaf18a
@rajatrao777 rajatrao777 mentioned this issue Apr 29, 2019
Merged
shilman added a commit that referenced this issue Apr 29, 2019
@shilman
updated npm broken link issue documentation #6556 (#6672)
d839ba0 
updated npm broken link issue documentation #6556
shilman added a commit that referenced this issue May 8, 2019
@shilman
updated npm broken link issue documentation #6556 (#6672)
797f69d 
updated npm broken link issue documentation #6556
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
bug documentation good first issue
Projects
None yet
Milestone
5.0.x
Development

Successfully merging a pull request may close this issue.

updated npm broken link issue documentation #6556 rajatrao777/storybook
2 participants
@shilman @kevbost