Core: colocate react stories #10901
Closed
Core: colocate react stories #10901
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
tooppaaa
commented
May 24, 2020
scripts/prepare.js
Outdated
| if ( | ||
| fs.lstatSync(filePath).isDirectory() || | ||
| /generators\/.+\/template.*/.test(filePath) || | ||
| /dist\/framework\/.*/.test(filePath) |
There was a problem hiding this comment.
absolutely not sure about this line
There was a problem hiding this comment.
What is this line trying to do?
There was a problem hiding this comment.
Last build step is cleaning up folders.
Because cli/src/framework/* is meant to be copied and not compiled, it's in the original format in dist.
beacause it's .ts / .tsx, we need to tell prepare to not clean this folder.
The thing is prepare is valid for all projects so I can't only filter for cli
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Issue: #10793
What I did
Move components from
@storybook/<framework>/demotocli/framework/<framework>/Copy them to user
/src/on init