-
-
Notifications
You must be signed in to change notification settings - Fork 9.3k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Fix addon panel layout styling #1170
Conversation
@@ -22,6 +22,7 @@ const downPanelStyle = downPanelInRight => ({ | |||
display: 'flex', | |||
flexDirection: downPanelInRight ? 'row' : 'column', | |||
alignItems: 'stretch', | |||
position: 'absolute', |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This will break scrolling inside the panel, I think?
I'm confused about this element being width & height : 100% AND also have padding..
Can you provide a reproducible case which caused you to find a problem you wanted to fix?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Whoops I missed the issue, I'm going have to try opening safari I guess 😃
Thanks for the PR! Can you give me a bit more background on why that was needed and can you provide a full steps to reproduce, so I can consider if this is the best solution? 😄 |
Codecov Report
@@ Coverage Diff @@
## master #1170 +/- ##
=======================================
Coverage 13.31% 13.31%
=======================================
Files 199 199
Lines 4588 4588
Branches 724 724
=======================================
Hits 611 611
Misses 3349 3349
Partials 628 628
Continue to review full report at Codecov.
|
🙇 Thanks for the feedback. Steps to reproduce:
|
Thank you for the attention to detail in your explanation, it helps! I'll rebase and merge! |
Issue: #1169
Steps to reproduce:
localhost:9001
using safariWhat I did
Add an additional css rule
position: absolute
to make sure the panel fill the entire space.How to test
Tested manually in safari, firefox and chrome.