-
-
Notifications
You must be signed in to change notification settings - Fork 9.3k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Fix bug in addons/graphql in reIndentQuery #1207
Conversation
Codecov Report
@@ Coverage Diff @@
## master #1207 +/- ##
==========================================
+ Coverage 13.64% 13.71% +0.07%
==========================================
Files 207 207
Lines 4640 4615 -25
Branches 517 516 -1
==========================================
Hits 633 633
+ Misses 3555 3530 -25
Partials 452 452
Continue to review full report at Codecov.
|
Thank you @jamsea ! I don't know a lot of users of this addon, if you're using it please let us know how, and what you'd like to see improved? |
@ndelangen thanks for merging. We're using GraphQL for our new projects at the NFL and we're using this add on for internal documentation. We're already using story book as internal documentation for all of our react components so being able to integrate GraphQL examples in the same system was a life saver. The only thing I wasn't able to figure out was adding an example GraphQL variable. Is there a way to do that currently or is that a new feature that would need to be developed? |
Well I know it's using https://github.com/graphql/graphiql and supports it, but maybe it needs an update? If you could help us out, that'd be great! |
@jamsea do you happen to have any public storybooks from NFL you can share? i'm documenting examples here (placeholder, will be redesigned): https://storybook.js.org/examples/ |
Issue:
Creating a multi line graphiql query causes storybook to error out in version 3. This is because it tries to run
join
on a string rather than an array.What I did
Move the bracket so
join
is always appended to an array rather than a string.How to test
Try creating a story with a multi-line graphiql query and loading it.