Addon-docs: Resolve vue-docgen-loader from @storybook/vue #12461
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
merceyz
force-pushed
the
merceyz/vue
branch
from
f671fd0
to
2922725
Compare
merceyz
force-pushed
the
merceyz/vue
branch
from
aea7ec2
to
75db58d
Compare
merceyz
changed the title
shilman
changed the title
Closed
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Issue
@storybook/addon-docsis declaringvue-docgen-apiandvue-docgen-loaderas peer dependencies which means@storybook/addon-essentialsneeds to declare them as well, but this means that the user needs to provide them while what we're actually after is to load them from@storybook/vue.Continuation of #11753 and #12383
What I did
Changed the resolution to get the
vue-docgen-loaderfrom@storybook/vueHow to test
The PnP e2e test has been updated and should be green