-
-
Notifications
You must be signed in to change notification settings - Fork 9.3k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
WIP - add vue support #1267
WIP - add vue support #1267
Changes from 1 commit
c3b35e6
fcd6283
7b53666
b1470eb
23aadf4
c23caa9
ccbbf6e
55aa3ff
e7b9b0a
6b21da8
cc546c5
d51f83e
9454fa7
d0dc873
385611b
9974a3b
bf00a9a
514f4b7
5a6472d
a93eba3
b41fda4
ff56861
765d394
9bd55bc
82d44e8
19dcfd9
db319e4
d9a3da5
5e66224
aef1f01
5784a79
bac1905
6255569
4c1daab
3e12ba1
b355060
4dd6b78
3260f7d
1e91907
838730f
2e3170d
040f4e0
68d237c
bc84ee6
8145ac3
d3c53c1
70a043f
8178ec1
043b5f1
5daa769
6c95ac9
6e8f869
c7efe5a
654be24
e35aeee
7be65d4
96031cd
d806c3f
d41655a
c7ddd09
f2926f4
cafa395
0605107
997f3d9
ec67cc5
d2f259b
929eb38
864e97e
83bb874
File filter
Filter by extension
Conversations
Jump to
Diff view
Diff view
There are no files selected for viewing
Original file line number | Diff line number | Diff line change |
---|---|---|
@@ -1,3 +1,3 @@ | ||
{ | ||
"presets": ["es2015", "es2016", "stage-0", "react"] | ||
"presets": ["env", "stage-0", "react"] | ||
} |
Original file line number | Diff line number | Diff line change |
---|---|---|
|
@@ -52,7 +52,7 @@ export default function() { | |
// Based on this CRA feature: https://github.com/facebookincubator/create-react-app/issues/253 | ||
modules: ['node_modules'].concat(nodePaths), | ||
alias: { | ||
'vue$': 'vue/dist/vue.esm.js' | ||
'vue': path.resolve(path.join(__dirname, '../../../node_modules', 'vue/dist/vue.esm.js')) | ||
There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. this needs a explanatory comment There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. why do you change it? 🤔 See the docs: There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. Not correct in our case because of webpack being in storybook/vue and not ine the example app. Not pointing to the correct dep will have webpack load 2 times vie and thus make it impossible to ise extension or global custom components There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. @kazupon I fyou could try to run the example s storybook and see if all the stories are working :) |
||
} | ||
}, | ||
performance: { | ||
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Notes?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Oups !