Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Build: Update example and app to Angular 11 #13141

Merged
merged 1 commit into from
Nov 18, 2020
Merged

Build: Update example and app to Angular 11 #13141

merged 1 commit into from
Nov 18, 2020

Conversation

ThibaudAV
Copy link
Contributor

@ThibaudAV ThibaudAV commented Nov 16, 2020 •
edited
Loading

Issue: na

What I did

Update to angular 11

How to test

  • Is this testable with Jest or Chromatic screenshots?

na

  • Does this need a new example in the kitchen sink apps?

na

  • Does this need an update to the documentation?

na

If your answer is yes to any of these, please make sure to include it in your PR.

@ThibaudAV ThibaudAV changed the title chore(angular): update to angular 11 Build: Update example to Angular 11 Nov 16, 2020
@ThibaudAV ThibaudAV changed the title Build: Update example to Angular 11 Build: Update example and app to Angular 11 Nov 16, 2020
@ThibaudAV ThibaudAV marked this pull request as ready for review November 17, 2020 07:34
@gaetanmaisse gaetanmaisse self-assigned this Nov 17, 2020
@gaetanmaisse gaetanmaisse added angular maintenance User-facing maintenance tasks labels Nov 18, 2020
@shilman shilman added this to the 6.1 core milestone Nov 18, 2020
shilman
shilman approved these changes Nov 18, 2020
View reviewed changes
Copy link
Member

@shilman shilman left a comment •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM! Thanks @ThibaudAV 🙏

@gaetanmaisse gaetanmaisse merged commit f701930 into storybookjs:next Nov 18, 2020
@lili2311 lili2311 mentioned this pull request Sep 20, 2023
Open
@lili2311 lili2311 mentioned this pull request Nov 25, 2023
Open
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@gaetanmaisse gaetanmaisse gaetanmaisse approved these changes

@shilman shilman shilman approved these changes

@alterx alterx Awaiting requested review from alterx

@igor-dv igor-dv Awaiting requested review from igor-dv

Assignees

@gaetanmaisse gaetanmaisse

Labels
angular maintenance User-facing maintenance tasks
Projects
None yet
Milestone
6.1 core
Development

Successfully merging this pull request may close these issues.
3 participants
@ThibaudAV @shilman @gaetanmaisse