UI: Simplify custom Sidebar styling by adding classNames to DOM elements #13155
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
tooppaaa
requested review from
igor-dv,
ndelangen and
tmeasday
as code owners
tooppaaa
commented
Nov 18, 2020
| <SearchField {...getRootProps({ refKey: '' }, { suppressRefError: true })}> | ||
| <SearchField | ||
| {...getRootProps({ refKey: '' }, { suppressRefError: true })} | ||
| className="search-field" |
There was a problem hiding this comment.
Previously accessed using nav.container.sidebar-container form
tooppaaa
commented
Nov 18, 2020
| @@ -124,7 +124,7 @@ const Result: FunctionComponent< | |||
| const nameMatch = matches.find((match: Match) => match.key === 'name'); | |||
| const pathMatches = matches.filter((match: Match) => match.key === 'path'); | |||
| const label = ( | |||
| <div> | |||
| <div className="search-result-item--label"> | |||
tooppaaa
commented
Nov 18, 2020
| @@ -202,7 +202,7 @@ export const SearchResults: FunctionComponent<{ | |||
| <ResultsList {...getMenuProps()}> | |||
| {results.length > 0 && !query && ( | |||
| <li> | |||
| <RootNode>Recently opened</RootNode> | |||
| <RootNode className="search-result-recentlyOpened">Recently opened</RootNode> | |||
There was a problem hiding this comment.
All invented in this (didn't exists before)
tooppaaa
commented
Nov 18, 2020
| @@ -77,6 +77,7 @@ const Node = React.memo<NodeProps>( | |||
| <LeafNode | |||
| key={id} | |||
| id={id} | |||
| className="sidebar-item" | |||
There was a problem hiding this comment.
already present in 6.0
| <RootNode | ||
| key={id} | ||
| id={id} | ||
| className="sidebar-subheading" |
There was a problem hiding this comment.
already present in 6.0
| {item.name} | ||
| <Action | ||
| type="button" | ||
| className="sidebar-subheading-action" |
| @@ -119,6 +128,7 @@ const Node = React.memo<NodeProps>( | |||
| <BranchNode | |||
| key={id} | |||
| id={id} | |||
| className="sidebar-item" | |||
There was a problem hiding this comment.
already present in 6.0 (they where all sidebar-item before)
ghengeveld
approved these changes
Nov 18, 2020
ghengeveld
changed the title
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Issue:
It became difficult to add style to the sidebar
What I did
add classnames back
How to test