-
-
Notifications
You must be signed in to change notification settings - Fork 9.3k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Core: Ensure node name
does not contain leading/trailing whitespace
#13275
Conversation
…ot contain leading/trailing whitespace.
name
does not contain leading/trailing whitespace
I'm surprised this didn't involve any test changes. Do we need a test for this case? |
Yes we do, but I'm not sure where to add it. This whole lib is untested. |
Untrue! |
@tmeasday I added a test. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
Issue: #13251
What I did
Primarily, this trims each part of the
title
(akakind
), after splitting it on/
:The
.map(part => part.trim())
is what's added. Everything else in this PR is refactoring. I'll leave comments to clarify.Pro tip: ignore whitespace changes when reviewing this 👍
How to test
If your answer is yes to any of these, please make sure to include it in your PR.