Misc: clean dependencies in apps and addons #13442
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Have both these packages as peerDep is causing a lot of `unmet peer dependency` warnings. However, there is no need to worry about them because there is a webpack alias in `@storybook/core` so all import of react in addons are aliased to the one from `@storybook/core`. For details, see #13194 I didn't use `*` as version range but the one used in `app/*` to have only 1 version in the monorepo `node_modules`.
gaetanmaisse
added
maintenance
shilman
reviewed
Dec 14, 2020
| @@ -52,6 +52,8 @@ | |||
| "core-js": "^3.0.1", | |||
| "global": "^4.3.2", | |||
| "lodash": "^4.17.15", | |||
| "react": "16.13.1", | |||
There was a problem hiding this comment.
@gaetanmaisse This doesn't seem right to me. If I'm a user writing a third party addon, what version of React should I target? Isn't a peer dependency appropriate for addons where we want it to use whatever version Storybook is using for the manager code?
|
To rework |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Issue: #13194
Plus, follow up on my comment from #13329
What I did
reactandreact-domto a regular dependency, one more time! For details, see Management ofreactandreact-domdependencies #13194How to test
unmeet peer dependencywarnings in e2e jobs (threw for storybook packages)