Addon-docs: Fix doc blocks imports to import from ESM/CJS #14841
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
shilman
requested review from
aaronmcadam,
alexandrebodin,
alterx,
igor-dv,
ndelangen,
stijnkoopal,
thomasbertet,
tmeasday and
usulpro
as code owners
Nx Cloud ReportCI ran the following commands for commit 412eb52. Click to see the status, the terminal output, and the build insights. 📂 See all runs for this branch
Sent with 💌 from NxCloud. |
shilman
changed the title
kylegach
reviewed
May 7, 2021
MIGRATION.md
Outdated
| @@ -209,7 +230,7 @@ Many Storybook packages are now available as ESModules in addition to CommonJS. | |||
|
|
|||
| ```js | |||
| // In your jest config | |||
| transformIgnorePatterns: ['/node_modules/(?!@storybook)'] | |||
| transformIgnorePatterns: ['/node_modules/(?!@storybook)']; | |||
There was a problem hiding this comment.
Tiny nit, but this line of config is likely either in an object or JSON, so the semi-colon is a syntax error.
More importantly, should we update the text above this to inform people that this isn't necessary in 6.3?
2 tasks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Issue: #13478
What I did
Move to importing from
@storybook/addon-docsinstead of@storybook/addon-docs/blocksso that we can import from either CJS or ESM automaticallyself-merging @ndelangen @kylegach
How to test
Does CI pass?