Controls: Update all controls to have explicit handling for undefined
#14899
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
And implement something close to the design.
Nx Cloud ReportCI ran the following commands for commit f692020. Click to see the status, the terminal output, and the build insights. 📂 See all runs for this branch
Sent with 💌 from NxCloud. |
This was referenced May 12, 2021
shilman
changed the title
undefinedundefined
Addon-docs: Remove all defaultValue eval-ing
Core: Add args enhancers + use in addon-actions
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Issue: #14579
What I did
@domyen the main thing I didn't complete was the green track for the range control. According to the internet it isn't really possible to only make the LHS green in webkit. I did it for FF/IE though. My styles are just indicative though, please fix.
I think most of the other controls pretty closely match what you had in mind but 🤷