Interactions: Show exceptions by non-instrumented code in panel

[ghengeveld]

Issue: #16585

What I did

Catch exceptions thrown in the play function so they don't trigger a redbox.
Log them to console and emit an event if this happens and pick it up in the Interactions addon.
Show the error in the addon panel (see screenshot).
Fixed serialization of error payload in STORY_THREW_EXCEPTION event.

How to test

• Is this testable with Jest or Chromatic screenshots? yes
• Does this need a new example in the kitchen sink apps? no
• Does this need an update to the documentation? no

If your answer is yes to any of these, please make sure to include it in your PR.

[nx-cloud]

☁️ Nx Cloud Report

CI is running/has finished running commands for commit 9be5035. As they complete they will appear below. Click to see the status, the terminal output, and the build insights.

📂 See all runs for this branch

---

✅ Successfully ran 1 target

• nx run-many --target=prepare --all --parallel=8 --max-parallel=15 -- --reset --optimized

---

Sent with 💌 from NxCloud.

[tmeasday]

I think we are missing tests here:

1. Does the Panel have tests?
2. We definitely should have a story that shows this new Exception component.
3. Can we add a PreviewWeb test for the case that the play function throws? Or is this already covered?

[shilman]

@tmeasday @ghengeveld what do we need to do to get this over the line?

[yannbf]

Hey @ghengeveld, given the stuff you did in the other PRs, is this something we should work on still?

[ghengeveld]

Hey @ghengeveld, given the stuff you did in the other PRs, is this something we should work on still?

I totally forgot about this one. I guess it would've been an alternative to adding any interactions that have an exception to the log. That is a nicer solution though so we don't need this PR for that purpose anymore. However there's also things which aren't instrumented that might throw an error. This PR does address those things, and I think it's much nicer to show those in the Interactions panel rather than a redbox.

[ghengeveld]

Still needs some tests for the Panel and possibly PreviewWeb.

[tmeasday]

I'm good with these changes as is, but have some suggestions for improvement maybe.

[ghengeveld]

@shilman This is ready to merge.

[shilman]

@ghengeveld @yannbf @tmeasday This is actually a breaking change, as we've seen today with the chromatic issue on PR #18894 and probably deserves its own entry in MIGRATION.md. WDYT?