Core: Remove start-/build-storybook from all frameworks #17899
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
☁️ Nx Cloud ReportCI is running/has finished running commands for commit dd2e9af. As they complete they will appear below. Click to see the status, the terminal output, and the build insights. 📂 See all runs for this branch ✅ Successfully ran 1 targetSent with 💌 from NxCloud. |
shilman
commented
Apr 26, 2022
| @@ -49,7 +49,7 @@ export const getConfig: WebpackBuilder['getConfig'] = async (options) => { | |||
| ...options, | |||
| babelOptions, | |||
| typescriptOptions, | |||
| [`${options.framework}Options`]: frameworkOptions, | |||
| frameworkOptions: framework?.options, | |||
There was a problem hiding this comment.
Need to:
- update
framework-preset-reactto useframeworkOptionsinstead ofreactOptions - update angular, etc.
- Add a MIGRATION.md note
- Update vite builder Fix vite builder to use
framework.optionsfor 7.0 #18059
| @@ -12,6 +13,7 @@ export const build = async (cliOptions: any) => { | |||
| docsMode: !!cliOptions.docs, | |||
| configType: 'PRODUCTION', | |||
| cache, | |||
| packageJson: readUpSync({ cwd: __dirname }).packageJson, | |||
There was a problem hiding this comment.
This should be the framework's package.json => #18058
MH4GF
added a commit
to MH4GF/storycap
that referenced
this pull request
Apr 3, 2023
MH4GF
added a commit
to MH4GF/storycap
that referenced
this pull request
Apr 3, 2023
8 tasks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Issue: N/A
What I did
This PR builds on #17898 to remove
start-storybookandbuild-storybookfrom all framework packages.Users should now use
sb devandsb buildinstead.How to test