Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix typing on useArgs #18122

Closed
wants to merge 6 commits into from
Closed

fix typing on useArgs #18122

Changes from 1 commit
Commits
Show all changes
6 commits
Select commit Hold shift + click to select a range
7331203
fix typing on useArgs
annacc-everlaw May 2, 2022
a1e55bb
fix build error and type things correctly
annacc-everlaw May 19, 2022
081e3e1
switch from string[] to (keyof TArgs)[]
annacc-everlaw May 19, 2022
d42a59a
Merge branch 'next' into fix-use-args-types
yannbf May 23, 2022
787fd9b
Merge branch 'next' into pr/18122
shilman Jun 27, 2022
fbba1b9
Update lib/addons/src/hooks.ts
ndelangen Jan 13, 2023
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
6 changes: 3 additions & 3 deletions lib/addons/src/hooks.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -424,17 +424,17 @@ export function useParameter<S>(parameterKey: string, defaultValue?: S): S | und
}

/* Returns current value of story args */
export function useArgs(): [Args, (newArgs: Args) => void, (argNames?: [string]) => void] {
export function useArgs<P = Args>(): [P, (newArgs: Partial<P>) => void, (argNames?: string[]) => void] {
const channel = addons.getChannel();
const { id: storyId, args } = useStoryContext();

const updateArgs = useCallback(
(updatedArgs: Args) => channel.emit(UPDATE_STORY_ARGS, { storyId, updatedArgs }),
(updatedArgs: Partial<P>) => channel.emit(UPDATE_STORY_ARGS, { storyId, updatedArgs }),
[channel, storyId]
);

const resetArgs = useCallback(
(argNames?: [string]) => channel.emit(RESET_STORY_ARGS, { storyId, argNames }),
(argNames?: string[]) => channel.emit(RESET_STORY_ARGS, { storyId, argNames }),
[channel, storyId]
);

Expand Down