Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Create frameworks & rename renderers #18201

Merged
merged 14 commits into from
Jun 6, 2022
Merged

Create frameworks & rename renderers #18201

merged 14 commits into from
Jun 6, 2022

Conversation

shilman
Copy link
Member

@shilman shilman commented May 11, 2022 •
edited
Loading

Issue: N/A

Telescoping PR, builds on #18114

What I did

  • Create webpack4 frameworks react-webpack4 etc.
  • Rename @storybook/renderer-react etc. @storybook/react

image

How to test

  • CI passes

@nx-cloud
Copy link

nx-cloud bot commented May 11, 2022 •
edited
Loading

☁️ Nx Cloud Report

CI is running/has finished running commands for commit f339e77. As they complete they will appear below. Click to see the status, the terminal output, and the build insights.

📂 See all runs for this branch

✅ Successfully ran 1 target

Sent with 💌 from NxCloud.

@github-actions
Copy link
Contributor

github-actions bot commented May 11, 2022 •
edited
Loading

Fails
🚫 PR is marked with "BREAKING CHANGE" label.

Generated by 🚫 dangerJS against f339e77

@shilman shilman changed the title Create webpack4 frameworks & rename renderer packages Create frameworks & rename renderers (4/N) May 12, 2022
@shilman shilman added maintenance User-facing maintenance tasks BREAKING CHANGE labels May 12, 2022
This was referenced May 21, 2022
Closed
Merged
@shilman shilman changed the title Create frameworks & rename renderers (4/N) Create frameworks & rename renderers Jun 6, 2022
Base automatically changed from future/webpack-tools to future/base June 6, 2022 16:18
@shilman shilman marked this pull request as ready for review June 6, 2022 16:19
@shilman shilman merged commit 9020934 into future/base Jun 6, 2022
@shilman shilman deleted the future/simplified-frameworks branch June 6, 2022 16:19
@shilman shilman removed the maintenance User-facing maintenance tasks label Jun 6, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
BREAKING CHANGE
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
1 participant
@shilman