Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Interactions: Collapse child interactions #18484

Merged
merged 6 commits into from
Jun 16, 2022

Conversation

ghengeveld
Copy link
Member

@ghengeveld ghengeveld commented Jun 15, 2022

Issue:
AP-1856

This collapses child interactions on waitFor and provides a toggle icon to reveal them.

Screen.Recording.2022-06-15.at.15.53.02.mov

How to test

  • Is this testable with Jest or Chromatic screenshots?

@nx-cloud
Copy link

nx-cloud bot commented Jun 15, 2022

☁️ Nx Cloud Report

CI is running/has finished running commands for commit 7defcaf. As they complete they will appear below. Click to see the status, the terminal output, and the build insights.

📂 See all runs for this branch


✅ Successfully ran 1 target

Sent with 💌 from NxCloud.

@ghengeveld ghengeveld requested a review from yannbf June 15, 2022 13:56
@ghengeveld ghengeveld changed the base branch from next to ghengeveld/ap-1950-fix-waitfor-behavior-while-debugging June 15, 2022 13:56
Copy link
Member

@shilman shilman left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

So nice @ghengeveld 😍

@ghengeveld
Copy link
Member Author

@shilman Ready to merge when the checks are green (save for cra-bench).

@yannbf
Copy link
Member

yannbf commented Jun 16, 2022

@ghengeveld could you update the mocks so we have stories for the collapse scenario? thanks!

Base automatically changed from ghengeveld/ap-1950-fix-waitfor-behavior-while-debugging to next June 16, 2022 16:08
@shilman shilman merged commit ef2bc81 into next Jun 16, 2022
@shilman shilman deleted the ghengeveld/ap-1856-collapsible-group-ui branch June 16, 2022 16:11
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants