Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Core: Handle v3 index in composition #18498

Merged
merged 6 commits into from
Jun 20, 2022

Conversation

tmeasday
Copy link
Member

What I did

  • Get types passing again in a couple test files I looked at (looks like TS got stricter 👍 )
  • Rationalize refs code a little bit (it was confusing that it was calling different things stories in different places).
  • Ensure we handle v3 story index files loaded via refs, in particular WRT docs entries.

How to test

Compose a 6.x Storybook into one of the example apps.

@nx-cloud
Copy link

nx-cloud bot commented Jun 17, 2022

☁️ Nx Cloud Report

CI is running/has finished running commands for commit b6ce456. As they complete they will appear below. Click to see the status, the terminal output, and the build insights.

📂 See all runs for this branch


✅ Successfully ran 1 target

Sent with 💌 from NxCloud.

@tmeasday tmeasday requested a review from shilman June 17, 2022 06:42
@tmeasday tmeasday added maintenance User-facing maintenance tasks composition labels Jun 17, 2022
@shilman shilman changed the title Handle v3 index in composition Core: Handle v3 index in composition Jun 17, 2022
@shilman
Copy link
Member

shilman commented Jun 18, 2022

@tmeasday this one is not building. maybe i resolved merge conflicts incorrectly?

Copy link
Member

@shilman shilman left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I'm a little fuzzy on the TypeScript changes for Module. @ndelangen can you please take a look also?

@shilman shilman merged commit 3803656 into future/docs2-core Jun 20, 2022
@shilman shilman deleted the tom/sb-306-handle-v3-index-in-composition branch June 20, 2022 12:10
@tmeasday
Copy link
Member Author

@shilman with the changes to using stricter typescript rules, the tests weren't happy with the looseness of the Module type. I tightened it up a little bit. I don't think it's super controversial but equally I'm happy to adjust if @ndelangen has different ideas.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
composition maintenance User-facing maintenance tasks
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants