Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Interactions: Prevent showing child exception while parent is still playing #18518

Merged

Conversation

ghengeveld
Copy link
Member

Issue: #16492

What I did

Override the "error" status of a child interaction to "playing" if its parent is still playing. This prevents exceptions within a waitFor callback to be rendered while it is still retrying.

How to test

  • Is this testable with Jest or Chromatic screenshots? no
  • Does this need a new example in the kitchen sink apps? no
  • Does this need an update to the documentation? no

If your answer is yes to any of these, please make sure to include it in your PR.

@nx-cloud
Copy link

nx-cloud bot commented Jun 20, 2022

☁️ Nx Cloud Report

We didn't find any information for the current pull request with the commit f45a51c.
You might need to set the 'NX_BRANCH' environment variable in your CI pipeline.

Check the Nx Cloud Github Integration documentation for more information.


Sent with 💌 from NxCloud.

@ghengeveld ghengeveld changed the title Prevent showing child exception while parent is still playing Interactions: Prevent showing child exception while parent is still playing Jun 20, 2022
Copy link
Member

@yannbf yannbf left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I'm assuming this needs the new version of @storybook/testing-library to work? Approving that based on this assumption and the fact I saw this working perfectly on your machine.

In the deployed Storybook (with an older version of testing-lib) the issue does happen.

@shilman shilman merged commit 0a38662 into next Jun 21, 2022
@shilman shilman deleted the ghengeveld/sb-268-prevent-waitfor-from-briefly-showing-an branch June 21, 2022 01:19
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants