Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Interactions: Add step function and support multiple levels of nesting #18555

Merged
merged 51 commits into from
Aug 19, 2022
Merged

Interactions: Add step function and support multiple levels of nesting #18555

merged 51 commits into from
Aug 19, 2022

Commits on Jul 5, 2022

  1. Add step function and support for deeply nested interactions

    @ghengeveld
    ghengeveld committed Jul 5, 2022
    Configuration menu
    Copy the full SHA
    ee3fe71 View commit details
    Browse the repository at this point in the history

  2. Fix bubbling multiple levels

    @ghengeveld
    ghengeveld committed Jul 5, 2022
    Configuration menu
    Copy the full SHA
    9c427fe View commit details
    Browse the repository at this point in the history

  3. Refactor stories to use step function

    @ghengeveld
    ghengeveld committed Jul 5, 2022
    Configuration menu
    Copy the full SHA
    fc1d62d View commit details
    Browse the repository at this point in the history

  4. Pull example stories into their own file

    @ghengeveld
    ghengeveld committed Jul 5, 2022
    Configuration menu
    Copy the full SHA
    b2a18cf View commit details
    Browse the repository at this point in the history

  5. Move examples to separate directory

    @ghengeveld
    ghengeveld committed Jul 5, 2022
    Configuration menu
    Copy the full SHA
    884e410 View commit details
    Browse the repository at this point in the history

  6. Stories for step function

    @ghengeveld
    ghengeveld committed Jul 5, 2022
    Configuration menu
    Copy the full SHA
    890d94a View commit details
    Browse the repository at this point in the history

  7. Document step function

    @ghengeveld
    ghengeveld committed Jul 5, 2022
    Configuration menu
    Copy the full SHA
    b646774 View commit details
    Browse the repository at this point in the history

  8. Concrete type for playContext

    @ghengeveld
    ghengeveld committed Jul 5, 2022
    Configuration menu
    Copy the full SHA
    34ff0a4 View commit details
    Browse the repository at this point in the history

  9. Drop needless async keyword

    @ghengeveld
    ghengeveld committed Jul 5, 2022
    Configuration menu
    Copy the full SHA
    7c92060 View commit details
    Browse the repository at this point in the history

  10. Remove unused import

    @ghengeveld
    ghengeveld committed Jul 5, 2022
    Configuration menu
    Copy the full SHA
    1b58c18 View commit details
    Browse the repository at this point in the history

  11. Fix step type definition

    @ghengeveld
    ghengeveld committed Jul 5, 2022
    Configuration menu
    Copy the full SHA
    5f5009e View commit details
    Browse the repository at this point in the history

  12. Fix step function injection

    @ghengeveld
    ghengeveld committed Jul 5, 2022
    Configuration menu
    Copy the full SHA
    c2ce170 View commit details
    Browse the repository at this point in the history

  13. Namespace events to storybook

    @ghengeveld
    ghengeveld committed Jul 5, 2022
    Configuration menu
    Copy the full SHA
    be40bce View commit details
    Browse the repository at this point in the history

  14. Fix tests

    @ghengeveld
    ghengeveld committed Jul 5, 2022
    Configuration menu
    Copy the full SHA
    09a302b View commit details
    Browse the repository at this point in the history

Commits on Jul 8, 2022

  1. Merge branch 'future/base' into ghengeveld/ap-1859-generic-step-function

    @ghengeveld
    ghengeveld committed Jul 8, 2022
    Configuration menu
    Copy the full SHA
    63d2f98 View commit details
    Browse the repository at this point in the history

  2. Pass playContext to step function

    @ghengeveld
    ghengeveld committed Jul 8, 2022
    Configuration menu
    Copy the full SHA
    640072e View commit details
    Browse the repository at this point in the history

  3. Fix signature

    @ghengeveld
    ghengeveld committed Jul 8, 2022
    Configuration menu
    Copy the full SHA
    26ec0e6 View commit details
    Browse the repository at this point in the history

Commits on Aug 4, 2022

  1. Merge branch 'next' into ghengeveld/ap-1859-generic-step-function

    @ghengeveld
    ghengeveld committed Aug 4, 2022
    Configuration menu
    Copy the full SHA
    6f4ca17 View commit details
    Browse the repository at this point in the history

  2. Fix mock data

    @ghengeveld
    ghengeveld committed Aug 4, 2022
    Configuration menu
    Copy the full SHA
    b6f9fe5 View commit details
    Browse the repository at this point in the history

  3. Fix weird async behavior

    @ghengeveld
    ghengeveld committed Aug 4, 2022
    Configuration menu
    Copy the full SHA
    931af52 View commit details
    Browse the repository at this point in the history

  4. Add default runStep function and export one from interactions addon

    @ghengeveld
    ghengeveld committed Aug 4, 2022
    Configuration menu
    Copy the full SHA
    697c8ea View commit details
    Browse the repository at this point in the history

  5. Use proper types

    @ghengeveld
    ghengeveld committed Aug 4, 2022
    Configuration menu
    Copy the full SHA
    e05b07d View commit details
    Browse the repository at this point in the history

Commits on Aug 5, 2022

  1. Instrument the step runner provided by the interactions addon

    @ghengeveld
    ghengeveld committed Aug 5, 2022
    Configuration menu
    Copy the full SHA
    0ba8a5e View commit details
    Browse the repository at this point in the history

  2. Add addon-interactions to be able to see the labeled step

    @ghengeveld
    ghengeveld committed Aug 5, 2022
    Configuration menu
    Copy the full SHA
    4909898 View commit details
    Browse the repository at this point in the history

  3. Better label

    @ghengeveld
    ghengeveld committed Aug 5, 2022
    Configuration menu
    Copy the full SHA
    226e211 View commit details
    Browse the repository at this point in the history

  4. Get rid of dependency on instrumenter from preview-web

    @ghengeveld
    ghengeveld committed Aug 5, 2022
    Configuration menu
    Copy the full SHA
    9b81022 View commit details
    Browse the repository at this point in the history

  5. No need for explicit default implementation, composeStepRunners takes… 

    … care of that
    @ghengeveld
    ghengeveld committed Aug 5, 2022
    Configuration menu
    Copy the full SHA
    7538375 View commit details
    Browse the repository at this point in the history

  6. Update lockfile

    @ghengeveld
    ghengeveld committed Aug 5, 2022
    Configuration menu
    Copy the full SHA
    4c90cfd View commit details
    Browse the repository at this point in the history

Commits on Aug 9, 2022

  1. Add missing await keywords

    @ghengeveld
    ghengeveld committed Aug 9, 2022
    Configuration menu
    Copy the full SHA
    9319812 View commit details
    Browse the repository at this point in the history

  2. Fix formatting in docs

    @ghengeveld
    ghengeveld committed Aug 9, 2022
    Configuration menu
    Copy the full SHA
    64c950b View commit details
    Browse the repository at this point in the history

  3. Move MaybePromise to Preview.ts

    @ghengeveld
    ghengeveld committed Aug 9, 2022
    Configuration menu
    Copy the full SHA
    51d74a7 View commit details
    Browse the repository at this point in the history

  4. Drop unused stepFunction property and its type definition

    @ghengeveld
    ghengeveld committed Aug 9, 2022
    Configuration menu
    Copy the full SHA
    f46a08c View commit details
    Browse the repository at this point in the history

Commits on Aug 10, 2022

  1. Always return chained promise so state will be restored before execut… 

    …ion continues
    @ghengeveld
    ghengeveld committed Aug 10, 2022
    Configuration menu
    Copy the full SHA
    501b7e1 View commit details
    Browse the repository at this point in the history

  2. Add test for step runner composition

    @ghengeveld
    ghengeveld committed Aug 10, 2022
    Configuration menu
    Copy the full SHA
    118fe17 View commit details
    Browse the repository at this point in the history

  3. Avoid step function in official-storybook for now

    @ghengeveld
    ghengeveld committed Aug 10, 2022
    Configuration menu
    Copy the full SHA
    7970c89 View commit details
    Browse the repository at this point in the history

  4. Fix projectAnnotations

    @ghengeveld
    ghengeveld committed Aug 10, 2022
    Configuration menu
    Copy the full SHA
    24fb939 View commit details
    Browse the repository at this point in the history

  5. Revert "Avoid step function in official-storybook for now" 

    This reverts commit 7970c89.
    @ghengeveld
    ghengeveld committed Aug 10, 2022
    Configuration menu
    Copy the full SHA
    5e56ec8 View commit details
    Browse the repository at this point in the history

Commits on Aug 12, 2022

  1. Merge branch 'next' into ghengeveld/ap-1859-generic-step-function

    @ghengeveld
    ghengeveld committed Aug 12, 2022
    Configuration menu
    Copy the full SHA
    3a61646 View commit details
    Browse the repository at this point in the history

  2. Fix step function in StoryStore v6

    @ghengeveld
    ghengeveld committed Aug 12, 2022
    Configuration menu
    Copy the full SHA
    2a70b8a View commit details
    Browse the repository at this point in the history

  3. Load step runner in Storyshots

    @ghengeveld
    ghengeveld committed Aug 12, 2022
    Configuration menu
    Copy the full SHA
    6a47756 View commit details
    Browse the repository at this point in the history

Commits on Aug 15, 2022

  1. Fix interactions count

    @ghengeveld
    ghengeveld committed Aug 15, 2022
    Configuration menu
    Copy the full SHA
    d76bbba View commit details
    Browse the repository at this point in the history

  2. Fix collapse to bust memoization

    @ghengeveld
    ghengeveld committed Aug 15, 2022
    Configuration menu
    Copy the full SHA
    60c6653 View commit details
    Browse the repository at this point in the history

  3. Nobody cares about the number of items to hide

    @ghengeveld
    ghengeveld committed Aug 15, 2022
    Configuration menu
    Copy the full SHA
    ff5e9e8 View commit details
    Browse the repository at this point in the history

Commits on Aug 16, 2022

  1. Merge branch 'next' into ghengeveld/ap-1859-generic-step-function

    @ghengeveld
    ghengeveld committed Aug 16, 2022
    Configuration menu
    Copy the full SHA
    44b17e9 View commit details
    Browse the repository at this point in the history

  2. Fix interactions count with collapsed items

    @ghengeveld
    ghengeveld committed Aug 16, 2022
    Configuration menu
    Copy the full SHA
    18dea52 View commit details
    Browse the repository at this point in the history

  3. Remove log statement

    @ghengeveld
    ghengeveld committed Aug 16, 2022
    Configuration menu
    Copy the full SHA
    b3585b9 View commit details
    Browse the repository at this point in the history

Commits on Aug 17, 2022

  1. Fix debugger behavior by ensuring we sync then jumping to the start

    @ghengeveld
    ghengeveld committed Aug 17, 2022
    Configuration menu
    Copy the full SHA
    cd0fe4e View commit details
    Browse the repository at this point in the history

  2. Merge branch 'next' into ghengeveld/ap-1859-generic-step-function

    @ghengeveld
    ghengeveld committed Aug 17, 2022
    Configuration menu
    Copy the full SHA
    8de3948 View commit details
    Browse the repository at this point in the history

  3. Flip boolean arg to have workable fallback

    @ghengeveld
    ghengeveld committed Aug 17, 2022
    Configuration menu
    Copy the full SHA
    5c0755f View commit details
    Browse the repository at this point in the history

  4. Update test

    @ghengeveld
    ghengeveld committed Aug 17, 2022
    Configuration menu
    Copy the full SHA
    9bd934a View commit details
    Browse the repository at this point in the history

Commits on Aug 19, 2022

  1. Merge branch 'next' into ghengeveld/ap-1859-generic-step-function

    @ghengeveld
    ghengeveld committed Aug 19, 2022
    Configuration menu
    Copy the full SHA
    bfa4326 View commit details
    Browse the repository at this point in the history