New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add step function to play context #18673

Merged

tmeasday merged 5 commits into next from tom/sb-468-add-step-function-to-play-context-and

Jul 29, 2022

Member

tmeasday commented Jul 10, 2022

What I did

See ComponentDriven/csf#48

How to test

See unit tests.

tmeasday requested a review from ghengeveld

July 10, 2022 11:34

nx-cloud bot commented Jul 10, 2022 •

edited

Loading

☁️ Nx Cloud Report

CI is running/has finished running commands for commit a1b36f5. As they complete they will appear below. Click to see the status, the terminal output, and the build insights.

📂 See all runs for this branch

✅ Successfully ran 1 target

nx run-many --target=prepare --all --parallel=8 --max-parallel=15 -- --reset --optimized

Sent with 💌 from NxCloud.

tmeasday changed the base branch from next to future/base

July 10, 2022 11:34

tmeasday added feature request addon: interactions labels

ghengeveld reviewed

View reviewed changes

addons/storyshots/storyshots-puppeteer/package.json Outdated Show resolved Hide resolved

ghengeveld reviewed

View reviewed changes

lib/store/src/types.ts Outdated Show resolved Hide resolved

ghengeveld reviewed

View reviewed changes

lib/store/src/csf/composeConfigs.ts Outdated Show resolved Hide resolved

ghengeveld reviewed

View reviewed changes

lib/store/src/csf/prepareStory.ts Outdated Show resolved Hide resolved

ghengeveld reviewed

View reviewed changes

lib/store/src/csf/stepRunners.test.ts Outdated Show resolved Hide resolved

ghengeveld reviewed

View reviewed changes

lib/store/src/csf/stepRunners.ts Outdated Show resolved Hide resolved

ghengeveld reviewed

View reviewed changes

lib/store/src/csf/stepRunners.ts Outdated Show resolved Hide resolved

tmeasday requested a review from ghengeveld

July 11, 2022 01:46

MichaelArestad assigned ghengeveld

Base automatically changed from future/base to next

July 25, 2022 10:37

tmeasday force-pushed the tom/sb-468-add-step-function-to-play-context-and branch from a1b36f5 to 2f4a8cd Compare

July 27, 2022 04:32

ghengeveld reviewed

View reviewed changes

code/addons/storyshots/storyshots-puppeteer/package.json Outdated Show resolved Hide resolved

ghengeveld approved these changes

View reviewed changes

code/lib/store/src/csf/prepareStory.test.ts Show resolved Hide resolved

tmeasday added 5 commits

July 28, 2022 19:33


          Add step to the prepared play function on Story

d1bcb5e


          Linting fixes

81e297e


          Add explanation about composeStepRunners

bb37491


          Improvements

0d176de


          Code comments

f95cb6e

tmeasday force-pushed the tom/sb-468-add-step-function-to-play-context-and branch from b9ebd0e to f95cb6e Compare

July 28, 2022 09:33

tmeasday merged commit 428a768 into next

tmeasday deleted the tom/sb-468-add-step-function-to-play-context-and branch

July 29, 2022 00:44

yannbf mentioned this pull request

Store: always call composeConfigs in setProjectAnnotations #18916

Merged

3 tasks

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

addon: interactions feature request