-
-
Notifications
You must be signed in to change notification settings - Fork 9.3k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Future - Create a CRA framework #18695
Closed
Closed
Changes from all commits
Commits
Show all changes
10 commits
Select commit
Hold shift + click to select a range
9682343
add CRA framework
ndelangen 1bd59f6
improve lib/cli CRA detection
ndelangen e85ce63
Update package.json
ndelangen 1c704ce
Merge branch 'future/base' into future/add-CRA-framework
ndelangen 54110c0
merge babel loader options
ndelangen a901725
update snapshots
ndelangen 5ce4634
Merge branch 'future/base' into future/add-CRA-framework
ndelangen ac7f4c7
Merge branch 'next' into future/base-with-next-merged
ndelangen d764cdf
add code so framework-react maps to renderer-react so files get copie…
ndelangen cdaad45
Merge branch 'next' into future/add-CRA-framework
ndelangen File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Original file line number | Diff line number | Diff line change |
---|---|---|
@@ -1,16 +1,8 @@ | ||
{ | ||
"extends": "../tsconfig.app.json", | ||
"exclude": [ | ||
"../src/karma.ts", | ||
"../src/**/*.spec.ts" | ||
], | ||
"include": [ | ||
"../src/**/*", | ||
"preview.ts" | ||
], | ||
"exclude": ["../src/karma.ts", "../src/**/*.spec.ts"], | ||
"include": ["../src/**/*", "preview.ts"], | ||
"compilerOptions": { | ||
"types": [ | ||
"@testing-library/jest-dom" | ||
] | ||
"types": ["@testing-library/jest-dom"] | ||
} | ||
} |
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Original file line number | Diff line number | Diff line change | ||||
---|---|---|---|---|---|---|
@@ -0,0 +1,37 @@ | ||||||
# Storybook for CRA | ||||||
|
||||||
Storybook for CRA is a UI development environment for your React components. | ||||||
With it, you can visualize different states of your UI components and develop them interactively. | ||||||
|
||||||
![Storybook Screenshot](https://github.com/storybookjs/storybook/blob/main/media/storybook-intro.gif) | ||||||
|
||||||
Storybook runs outside of your app. | ||||||
So you can develop UI components in isolation without worrying about app specific dependencies and requirements. | ||||||
|
||||||
## Getting Started | ||||||
|
||||||
```sh | ||||||
cd my-react-app | ||||||
npx sb init | ||||||
There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more.
Suggested change
|
||||||
``` | ||||||
|
||||||
For more information visit: [storybook.js.org](https://storybook.js.org) | ||||||
|
||||||
--- | ||||||
|
||||||
Storybook also comes with a lot of [addons](https://storybook.js.org/addons) and a great API to customize as you wish. | ||||||
You can also build a [static version](https://storybook.js.org/docs/react/sharing/publish-storybook) of your Storybook and deploy it anywhere you want. | ||||||
|
||||||
Here are some featured storybooks that you can reference to see how Storybook works: | ||||||
|
||||||
- [Demo of Storybook Design System](https://storybook.js.org/design-system) - [source](https://github.com/storybookjs/design-system) | ||||||
|
||||||
## Create React App | ||||||
|
||||||
TODO | ||||||
There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. TODO! |
||||||
|
||||||
## Docs | ||||||
|
||||||
- [Basics](https://storybook.js.org/docs/react/get-started/introduction) | ||||||
- [Configurations](https://storybook.js.org/docs/react/configure/overview) | ||||||
- [Addons](https://storybook.js.org/docs/react/configure/storybook-addons) |
Oops, something went wrong.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
What's the idea behind this construct?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
To add a hidden property to the rule object, so it's easier to identify when you want to filter them out