Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Vite: Add builder, react, vue3 frameworks #18982

Closed
wants to merge 60 commits into from
Closed

Vite: Add builder, react, vue3 frameworks #18982

wants to merge 60 commits into from

Conversation

shilman
Copy link
Member

@shilman shilman commented Aug 22, 2022

Issue: N/A

What I did

  • Add builder-vite to monorepo
  • Add core-vite package (WIP)
  • Add react-vite framework
  • Add vue3-vite framework
  • Remove react/vue3-specific code from builder

How to test

Terminal 1:

cd code
yarn
yarn bootstrap --prep
yarn generate-repros-next --template vue3-vite/default-js --local-registry

Terminal 2:

cd repros/vue3-vite/default-js/after-storybook
yarn storybook

IanVS and others added 30 commits August 12, 2022 23:25
@IanVS
Move builder-vite files into monorepo
b3c1f81 
They're copied mostly straight, as-is from their old versions.  Adjustments will
be made in subsequent commits.
@IanVS
Add storybook dependencies
f80ef5f 
These were all implicit dependencies before, which caused problems for pnpm
@IanVS
Update package.json
bc4828a
@IanVS
Fix (most) linting errors
ecfc444
@IanVS
Add builder-vite to nx and workspace
fe4c852
@shilman
Vite core, react, and example app (WIP)
01e3663
@IanVS
Use monorepo version of builder-vite in example
aef0330
@IanVS
Move input files out of src
1f3c1f8 
They need to be accessible from dist, as well
@IanVS
Fix linting / typescript errors
67456fd
@IanVS
Remove plugins that moved to react-vite
aaedc2a
@IanVS
Remove @vitejs/plugin-react, it's added in every framework
b6908f7
@IanVS
[hack] remove exports from package.json
099771b 
It's causing the cjs file to always be chosen, which breaks in the browser.
@IanVS
Disable source loader plugin
c4f456d 
It seems to have broken, maybe after 631795b
@IanVS
Disable docs
49a3f87 
Not working yet
@shilman
Merge branch 'next' into vite-frameworks
da507a2
@shilman
Fix react-vite builder dependency
2a9f89a
@shilman
Add vite packages to CLI versions
441a5c1
@shilman
Merge branch 'next' into vite-frameworks
fd0de66
@shilman
Add react-vite repros
7389a38
@shilman
Fix exports map for ESM
60819ff
@shilman
CLI: Fix vite preview-head hack for SB7
1859ad6
@shilman
Fix react-vite preset
5e7299d
@shilman
Force repro generator to use yarn
47e39a2
@shilman
Add vue3-vite framework and repro template
3a991b4
@shilman
Clean up legacy typescript annotations
ef5917b
@shilman
clean up unused bin files
ca839d0
@shilman
Remove vue-specific code from vite builder
a3cec55
@shilman
Vue3-vite: Fix bad config merge
1eb6339
@shilman
CLI: Fix local repro publishing
a3b53da
@shilman
Remove unnecessary file
00465ba
shilman and others added 25 commits August 22, 2022 22:56
@shilman
Fix linting errors, take two
69d62e4
@shilman
Fix parallelism
eb24506
@ndelangen
add missing core-vite ref in package.json
71d7ee7
@ndelangen
Merge branch 'vite-frameworks' of github.com:storybookjs/storybook in…
495b75f 
…to vite-frameworks
@shilman
Core: Fix null stats.toJson() for vite builder
6a4a0bd
@shilman
Merge branch 'vite-frameworks' of github.com:storybookjs/storybook in…
e53d6b2 
…to vite-frameworks
@shilman
Trigger an update of the repro-templates-temp repo
f194030
@shilman
Merge branch 'next' into vite-frameworks
627a8cf
@shilman
Try addUser to local registry
9e0bd60
@shilman
Generate-repros: Run node14 on GH action to fix publish
2123331
@shilman
Tweak setup-node in GH action
3184258
@shilman
denug
cfe1992
@shilman
Merge branch 'next' into vite-frameworks
8778255
@shilman
Generate-repros: run local registry outside of loop
88c244d
@shilman
Debug publish
38df274
@shilman
Fix node14 for generate-repros-next
704559a
@shilman
Why is generate-repros-next GH action hanging?
e2c0677
@shilman
Debugging
22d4ae1
@shilman
More debugging
baacfcd
@shilman
Even more debugging
bda22cb
@shilman
Even more more debugging
57e8de6
@shilman
Generate-repros: Kill dangling processes
254736c
@shilman
Why is node running?
61406a8
@shilman
Debug abort signal
ca16737
@shilman
Always run addUser in the registry, cleanup
3248f9f
@shilman
Copy link
Member Author

shilman commented Aug 23, 2022

Replaced by #19002

@shilman shilman closed this Aug 23, 2022
@stof stof deleted the vite-frameworks branch August 31, 2022 12:58
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
builder-vite feature request react vue3
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@shilman @IanVS @ndelangen