Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Core: Restore /preview etc package exports; return unresolved path from presets. #19045

Merged
merged 9 commits into from
Aug 31, 2022
Merged

Core: Restore /preview etc package exports; return unresolved path from presets. #19045

merged 9 commits into from
Aug 31, 2022

Commits on Aug 29, 2022

  1. Fix addons in examples. 

    Allow `preview.js` etc to be the name of the package exports
    @tmeasday
    tmeasday committed Aug 29, 2022
    Configuration menu
    Copy the full SHA
    57d082c View commit details
    Browse the repository at this point in the history

Commits on Aug 30, 2022

  1. Don't return resolved path from browser preset entries 

    Instead, just return the import path unresolved
    @tmeasday
    tmeasday committed Aug 30, 2022
    Configuration menu
    Copy the full SHA
    57d5b1a View commit details
    Browse the repository at this point in the history

  2. Revert changes to exports fields of addons/renderers 

    All of Node, Webpack and Vite can `import('<pkg>/preview')` etc, as long as the `exports` map is there and setup like so. If the `exports` map is not there, then they can import `node_modules/<pkg>/preview.js` instead.

The issue occurred when an export map existed but Vite tried to import a path that wasn't defined in there.
    @tmeasday
    tmeasday committed Aug 30, 2022
    Configuration menu
    Copy the full SHA
    7eae837 View commit details
    Browse the repository at this point in the history

  3. Use pseudo absolute exports for preview/manager entries

    @tmeasday
    tmeasday committed Aug 30, 2022
    Configuration menu
    Copy the full SHA
    e3f0e26 View commit details
    Browse the repository at this point in the history

  4. Remove spurious log

    @tmeasday
    tmeasday committed Aug 30, 2022
    Configuration menu
    Copy the full SHA
    c29a912 View commit details
    Browse the repository at this point in the history

  5. Fix typo

    @tmeasday
    tmeasday committed Aug 30, 2022
    Configuration menu
    Copy the full SHA
    bb294e9 View commit details
    Browse the repository at this point in the history

  6. Update comments

    @tmeasday
    tmeasday committed Aug 30, 2022
    Configuration menu
    Copy the full SHA
    5aadc0f View commit details
    Browse the repository at this point in the history

  7. Restore svelte exports properly

    @tmeasday
    tmeasday committed Aug 30, 2022
    Configuration menu
    Copy the full SHA
    9d689a8 View commit details
    Browse the repository at this point in the history

  8. Merge remote-tracking branch 'origin/next' into tom/sb-697-investigat… 

    …e-chromatic-issues-on-next
    @tmeasday
    tmeasday committed Aug 30, 2022
    Configuration menu
    Copy the full SHA
    2e50d63 View commit details
    Browse the repository at this point in the history