Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

CI: Fix test-runner build step #19255

Merged
merged 13 commits into from
Oct 10, 2022
Merged

CI: Fix test-runner build step #19255

Show file tree
Hide file tree
Changes from 9 commits
Commits
Show all changes
13 commits
Select commit Hold shift + click to select a range
5be16b9
CI: Upgrade to latest test-runner
shilman Sep 26, 2022
8d2f696
use index-json as default for test-runner task
yannbf Sep 27, 2022
9167be4
skip sandbox error stories in CI
yannbf Sep 27, 2022
5191d43
fix logic in specifier mapping
yannbf Sep 27, 2022
1017241
Merge branch 'next' into shilman/upgrade-test-runner
shilman Oct 3, 2022
962ed90
Merge branch 'next' into shilman/upgrade-test-runner
shilman Oct 8, 2022
5054605
Skip error stories in the test runner only
shilman Oct 8, 2022
ccb3a80
Merge branch 'next' into shilman/upgrade-test-runner
shilman Oct 9, 2022
42158d6
Fix implicit type
shilman Oct 9, 2022
8495960
Try no index-json
shilman Oct 10, 2022
ca03e35
Try waiting on the init promise
tmeasday Oct 10, 2022
e5e43a8
Let's move that await to the store
tmeasday Oct 10, 2022
190de86
Ensure we wait in preview web also
tmeasday Oct 10, 2022
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
4 changes: 4 additions & 0 deletions code/renderers/react/template/stories/errors.stories.tsx
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -9,6 +9,10 @@ export default {
storyshots: { disable: true },
chromatic: { disable: true },
},
decorators: [
// Skip errors if we are running in the test runner
(storyFn: any) => window?.navigator?.userAgent?.match(/StorybookTestRunner/) || storyFn(),
tmeasday marked this conversation as resolved.
Show resolved Hide resolved
],
};

export const RenderThrows = {
Expand Down
4 changes: 2 additions & 2 deletions scripts/tasks/test-runner.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -14,11 +14,11 @@ export const testRunner: Task = {

// We could split this out into a separate task if it became annoying
const publishController = await servePackages({});
await exec(`yarn add --dev @storybook/test-runner@0.7.1-next.0`, execOptions);
await exec(`yarn add --dev @storybook/test-runner`, execOptions);

const storybookController = await serveSandbox(builtSandboxDir, {});

await exec(`yarn test-storybook --url http://localhost:8001 --junit`, {
await exec(`yarn test-storybook --url http://localhost:8001 --junit --index-json`, {
...execOptions,
env: {
JEST_JUNIT_OUTPUT_FILE: junitFilename,
Expand Down