Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

refactor(angular): drop support for angular < 13 #19368

Merged
merged 2 commits into from
Oct 6, 2022
Merged
Show file tree
Hide file tree
Changes from all commits
Commits
File filter

Filter by extension

Filter by extension


Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
8 changes: 8 additions & 0 deletions MIGRATION.md
Original file line number Diff line number Diff line change
Expand Up @@ -23,6 +23,7 @@
- [Removed STORYBOOK_REACT_CLASSES global](#removed-storybook_react_classes-global)
- [Icons API changed](#icons-api-changed)
- ['config' preset entry replaced with 'previewAnnotations'](#config-preset-entry-replaced-with-previewannotations)
- [Dropped support for Angular 12 and below](#dropped-support-for-angular-12-and-below)
- [Docs Changes](#docs-changes)
- [Standalone docs files](#standalone-docs-files)
- [Referencing stories in docs files](#referencing-stories-in-docs-files)
Expand Down Expand Up @@ -555,6 +556,13 @@ The preset field `'config'` has been replaced with `'previewAnnotations'`. `'con

Additionally, the internal field `'previewEntries'` has been removed. If you need a preview entry, just use a `'previewAnnotations'` file and don't export anything.

#### Dropped support for Angular 12 and below

Official [Angular 12 LTS support ends Nov 2022](https://angular.io/guide/releases#actively-supported-versions). With that, Storybook also drops its support
for Angular 12 and below.

In order to use Storybook 7.0, you need to upgrade to at least Angular 13.

#### Vue2 DOM structure changed

In 6.x, `@storybook/vue` would replace the "root" element (formerly `#root`, now `#storybook-root`) with a new node that contains the rendered children. This was problematic because it broke the `play` function, which often starts with `within(canvasElement)` and the old `canvasElement` would get replaced out from under the play function.
Expand Down
4 changes: 2 additions & 2 deletions code/addons/storyshots/storyshots-core/package.json
Original file line number Diff line number Diff line change
Expand Up @@ -77,8 +77,8 @@
"vue-jest": "^5.0.0-alpha.8"
},
"peerDependencies": {
"@angular/core": ">=6.0.0",
"@angular/platform-browser-dynamic": ">=6.0.0",
"@angular/core": ">=13.0.0",
"@angular/platform-browser-dynamic": ">=13.0.0",
"@storybook/angular": "*",
"@storybook/react": "*",
"@storybook/vue": "*",
Expand Down
22 changes: 11 additions & 11 deletions code/frameworks/angular/package.json
Original file line number Diff line number Diff line change
Expand Up @@ -97,17 +97,17 @@
"webpack": "5"
},
"peerDependencies": {
"@angular-devkit/architect": ">=0.8.9",
"@angular-devkit/build-angular": ">=0.8.9 || >= 12.0.0",
"@angular-devkit/core": "^0.6.1 || >=7.0.0",
"@angular/cli": ">=6.0.0",
"@angular/common": ">=6.0.0",
"@angular/compiler": ">=6.0.0",
"@angular/compiler-cli": ">=6.0.0",
"@angular/core": ">=6.0.0",
"@angular/forms": ">=6.0.0",
"@angular/platform-browser": ">=6.0.0",
"@angular/platform-browser-dynamic": ">=6.0.0",
"@angular-devkit/architect": ">=0.1300.0",
"@angular-devkit/build-angular": ">=13.0.0",
"@angular-devkit/core": ">=13.0.0",
"@angular/cli": ">=13.0.0",
"@angular/common": ">=13.0.0",
"@angular/compiler": ">=13.0.0",
"@angular/compiler-cli": ">=13.0.0",
"@angular/core": ">=13.0.0",
"@angular/forms": ">=13.0.0",
"@angular/platform-browser": ">=13.0.0",
"@angular/platform-browser-dynamic": ">=13.0.0",
"@babel/core": "*",
"@nrwl/workspace": "14.6.1",
"rxjs": "^6.0.0 || ^7.4.0",
Expand Down
1 change: 0 additions & 1 deletion code/frameworks/angular/src/preset.ts
Original file line number Diff line number Diff line change
Expand Up @@ -3,7 +3,6 @@ import type { PresetProperty } from '@storybook/core-common';
import { StorybookConfig } from './types';

export const addons: PresetProperty<'addons', StorybookConfig> = [
require.resolve('./server/framework-preset-angular'),
require.resolve('./server/framework-preset-angular-cli'),
require.resolve('./server/framework-preset-angular-ivy'),
require.resolve('./server/framework-preset-angular-docs'),
Expand Down

This file was deleted.

42 changes: 0 additions & 42 deletions code/frameworks/angular/src/server/__tests__/ts_config.test.ts

This file was deleted.

This file was deleted.

85 changes: 0 additions & 85 deletions code/frameworks/angular/src/server/angular-cli-webpack-12.2.x.js

This file was deleted.

Loading