Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Re-enable svelte-vite/default-ts template #19369

Merged
merged 1 commit into from
Oct 6, 2022
Merged

Re-enable svelte-vite/default-ts template #19369

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
12 changes: 6 additions & 6 deletions .circleci/config.yml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -316,7 +316,7 @@ jobs:
executor:
class: medium+
name: sb_node_14_browsers
parallelism: 12
parallelism: 13
steps:
- git-shallow-clone/checkout_advanced:
clone_options: '--depth 1 --verbose'
Expand All @@ -336,7 +336,7 @@ jobs:
executor:
class: medium+
name: sb_node_14_browsers
parallelism: 11
parallelism: 13
steps:
- git-shallow-clone/checkout_advanced:
clone_options: '--depth 1 --verbose'
Expand All @@ -352,7 +352,7 @@ jobs:
executor:
class: medium+
name: sb_node_14_browsers
parallelism: 12
parallelism: 13
steps:
- git-shallow-clone/checkout_advanced:
clone_options: '--depth 1 --verbose'
Expand All @@ -372,7 +372,7 @@ jobs:
executor:
class: medium+
name: sb_node_14_browsers
parallelism: 12
parallelism: 13
steps:
- git-shallow-clone/checkout_advanced:
clone_options: '--depth 1 --verbose'
Expand All @@ -388,7 +388,7 @@ jobs:
executor:
class: medium+
name: sb_node_14_browsers
parallelism: 12
parallelism: 13
steps:
- git-shallow-clone/checkout_advanced:
clone_options: '--depth 1 --verbose'
Expand All @@ -404,7 +404,7 @@ jobs:
executor:
class: medium+
name: sb_playwright
parallelism: 12
parallelism: 13
steps:
- git-shallow-clone/checkout_advanced:
clone_options: '--depth 1 --verbose'
Expand Down
24 changes: 10 additions & 14 deletions code/lib/cli/src/repro-templates.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -120,20 +120,16 @@ const svelteViteTemplates = {
builder: '@storybook/builder-vite',
},
},
/*
* I disabled this, because it was flaky
* TODO: we should fixd the instability and re-enable it
*/
// 'svelte-vite/default-ts': {
// name: 'Svelte Vite (TS)',
// script: 'yarn create vite . --template svelte-ts',
// cadence: ['ci', 'daily', 'weekly'],
// expected: {
// framework: '@storybook/svelte-vite',
// renderer: '@storybook/svelte',
// builder: '@storybook/builder-vite'
// }
// }
'svelte-vite/default-ts': {
name: 'Svelte Vite (TS)',
script: 'yarn create vite . --template svelte-ts',
cadence: ['ci', 'daily', 'weekly'],
expected: {
framework: '@storybook/svelte-vite',
renderer: '@storybook/svelte',
builder: '@storybook/builder-vite',
},
},
};

const litViteTemplates = {
Expand Down