Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Vite: Include user config optimizeDeps in final optimizeDeps #20313

Merged
merged 2 commits into from
Dec 19, 2022
Merged

Vite: Include user config optimizeDeps in final optimizeDeps #20313

Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
61c9f99
Include user config `optimizeDeps` in final `optimizeDeps`
agarun Dec 16, 2022
586ebce
Merge remote-tracking branch 'origin/next' into optimizedeps-combine
IanVS Dec 18, 2022
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
3 changes: 2 additions & 1 deletion code/lib/builder-vite/src/optimizeDeps.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -114,11 +114,12 @@ export async function getOptimizeDeps(config: ViteInlineConfig, options: Extende
const include = await asyncFilter(INCLUDE_CANDIDATES, async (id) => Boolean(await resolve(id)));

const optimizeDeps: UserConfig['optimizeDeps'] = {
...config.optimizeDeps,
// We don't need to resolve the glob since vite supports globs for entries.
entries: stories,
// We need Vite to precompile these dependencies, because they contain non-ESM code that would break
// if we served it directly to the browser.
include,
include: [...include, ...(config.optimizeDeps?.include || [])],
};

return optimizeDeps;
Expand Down