Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix trim vulnerability #20371

Merged
merged 2 commits into from
Dec 23, 2022
Merged

Fix trim vulnerability #20371

merged 2 commits into from
Dec 23, 2022

Commits on Dec 21, 2022

  1. Fix trim vulnerability

    Upgrade `@storybook/linter-config` to the latest version (`3.1.2`) to
    fix the `trim` vulnerability issue.
    
    `[email protected]` has a known vulnerability with high severity:
    https://security.snyk.io/vuln/SNYK-JS-TRIM-1017038.
    
    Here is the path to `trim` before this commit:
    
    ```
    └─ @storybook/root@workspace:.
       └─ @storybook/linter-config@npm:2.5.0 [cfb4f] (via npm:^2.5.0 [cfb4f])
          └─ remark-cli@npm:8.0.1 (via npm:^8.0.0)
             └─ remark@npm:12.0.1 (via npm:^12.0.0)
                └─ remark-parse@npm:8.0.3 (via npm:^8.0.0)
                   └─ trim@npm:0.0.1 (via npm:0.0.1)
    ```
    
    I checked that there is no `trim` in the dependencies in the __./code__
    folder after this commit. You can check it by running the following.
    
    ```sh
    yarn why -R trim
    ```
    
    The latest version of `@storybook/linter-config` is also used in the
    __./scripts__ folder.
    timur-svoboda committed Dec 21, 2022
    Configuration menu
    Copy the full SHA
    ec95642 View commit details
    Browse the repository at this point in the history

Commits on Dec 23, 2022

  1. Configuration menu
    Copy the full SHA
    a5b6711 View commit details
    Browse the repository at this point in the history