Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Core: Fix module guard in non-webpack environments #22085

Merged
merged 2 commits into from
Apr 17, 2023

Conversation

shilman
Copy link
Member

@shilman shilman commented Apr 14, 2023

Closes #22046

What I did

Ensure module variable actually exists every place that it is used.

How to test

I don't have a repro, so can't easily test. However, I think this is a safe check. @ndelangen WDYT?

@shilman shilman added bug patch:yes Bugfix & documentation PR that need to be picked to main branch core labels Apr 14, 2023
@shilman shilman changed the title Core: Guard against webpack HMR decline in non-webpack environments Core: Guard against module usage in non-webpack environments Apr 14, 2023
@shilman shilman changed the title Core: Guard against module usage in non-webpack environments Core: Fix module guard in non-webpack environments Apr 14, 2023
@valentinpalkovic valentinpalkovic merged commit 2cad914 into next Apr 17, 2023
@valentinpalkovic valentinpalkovic deleted the shilman/22046-typeof-module branch April 17, 2023 14:14
@shilman shilman added the patch:done Patch/release PRs already cherry-picked to main/release branch label Apr 18, 2023
shilman pushed a commit that referenced this pull request Apr 18, 2023
Core: Fix `module` guard in non-webpack environments
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug core patch:done Patch/release PRs already cherry-picked to main/release branch patch:yes Bugfix & documentation PR that need to be picked to main branch
Projects
None yet
Development

Successfully merging this pull request may close these issues.

[Bug]: storybook v7 + Cypress 12.9 component Testing broken for React
3 participants