Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Chore:(Docs) Add TS version of testing-library snippet #22256

Merged
merged 3 commits into from
May 10, 2023

Conversation

JungHoe
Copy link
Contributor

@JungHoe JungHoe commented Apr 26, 2023

Closes #

What I did

Add TS version of testing-library snippet

How to test

Checklist

  • Make sure your changes are tested (stories and/or unit, integration, or end-to-end tests)
  • Make sure to add/update documentation regarding your changes
  • If you are deprecating/removing a feature, make sure to update
    MIGRATION.MD

Maintainers

  • If this PR should be tested against many or all sandboxes,
    make sure to add the ci:merged or ci:daily GH label to it.
  • Make sure this PR contains one of the labels below.

["cleanup", "BREAKING CHANGE", "feature request", "bug", "documentation", "maintenance", "dependencies", "other"]

@JungHoe JungHoe force-pushed the code-snippets-for-framework branch 2 times, most recently from d36564d to 6744f5b Compare April 26, 2023 12:27
@JungHoe JungHoe force-pushed the code-snippets-for-framework branch from 6744f5b to 9b95eaa Compare April 26, 2023 13:20
@jonniebigodes jonniebigodes self-assigned this Apr 26, 2023
@jonniebigodes jonniebigodes added documentation patch:yes Bugfix & documentation PR that need to be picked to main branch labels Apr 26, 2023
@jonniebigodes
Copy link
Contributor

@JungHoe thanks for taking the time to put together this pull request and feature in the snippet. Appreciated 🙏 !

Looks good to me, going to merge this

Hope you have a great day.

Stay safe

@jonniebigodes jonniebigodes merged commit 7546fbb into storybookjs:next May 10, 2023
@shilman shilman added the patch:done Patch/release PRs already cherry-picked to main/release branch label May 12, 2023
shilman pushed a commit that referenced this pull request May 12, 2023
Chore:(Docs) Add TS version of testing-library snippet
@JungHoe JungHoe deleted the code-snippets-for-framework branch May 16, 2023 04:22
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
documentation patch:done Patch/release PRs already cherry-picked to main/release branch patch:yes Bugfix & documentation PR that need to be picked to main branch
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants