Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Docs: Fix scroll location on docs navigation #22714

Merged
merged 2 commits into from
Jun 21, 2023

Conversation

gitstart-storybook
Copy link
Collaborator

@gitstart-storybook gitstart-storybook commented May 24, 2023

Issue: #22473

What I did

  • Added document.documentElement.scrollTop = 0

How to test

Demo

Screen.Recording.2023-05-23.at.15.24.09.mov

@gitstart-storybook gitstart-storybook self-assigned this May 24, 2023
@gitstart-storybook gitstart-storybook marked this pull request as ready for review May 24, 2023 05:06
@gitstart-storybook gitstart-storybook removed their assignment Jun 14, 2023
@shilman shilman changed the title fix: scroll location persist between docs Docs: Fix scroll location across docs navigation Jun 14, 2023
@shilman shilman changed the title Docs: Fix scroll location across docs navigation Docs: Fix scroll location on docs navigation Jun 14, 2023
@ndelangen ndelangen merged commit a8c1570 into next Jun 21, 2023
@ndelangen ndelangen deleted the fix/doc-scroll-location-persist branch June 21, 2023 08:43
@github-actions github-actions bot mentioned this pull request Jun 21, 2023
12 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

[Bug]: Scroll location persists between doc pages in Storybook 7
3 participants