Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

added information that jest is not globally available #22876

Merged
merged 3 commits into from
Jun 26, 2023

Conversation

pascalfiv
Copy link
Contributor

@pascalfiv pascalfiv commented Jun 1, 2023

this was very hard to find out so maybe someones would be happy to have that information here.

Closes #

What I did

added an explanation of how to import jest correctly for storybook interactions tests

How to test

N/A

Checklist

N/A

Maintainers

  • If this PR should be tested against many or all sandboxes,
    make sure to add the ci:merged or ci:daily GH label to it.
  • Make sure this PR contains one of the labels below.

[ "documentation"]

this was very hard to find out so maybe someones would be happy to have that information here.
@jonniebigodes jonniebigodes added documentation patch:yes Bugfix & documentation PR that need to be picked to main branch labels Jun 3, 2023
@jonniebigodes jonniebigodes self-assigned this Jun 3, 2023
Copy link
Contributor

@jonniebigodes jonniebigodes left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@pascalfiv sorry for the delayed response on your pull request and appreciate you taking the time to put it together and help us improve the documentation. Left a small suggestion for you to look at.

Let me know, and we'll go from there.

Looking forward to hearing from you.

Have a fantastic weekend.

Stay safe

docs/essentials/interactions.md Outdated Show resolved Hide resolved
@jonniebigodes
Copy link
Contributor

@pascalfiv thanks for addressing the feedback so promptly. Going to merge this once the checklist clears.

Have a fantastic week.

Stay safe

@jonniebigodes jonniebigodes merged commit f57e67f into storybookjs:next Jun 26, 2023
@github-actions github-actions bot mentioned this pull request Jun 26, 2023
12 tasks
JReinhold pushed a commit that referenced this pull request Jun 26, 2023
added information that jest is not globally available

(cherry picked from commit f57e67f)
@github-actions github-actions bot mentioned this pull request Jun 26, 2023
18 tasks
JReinhold pushed a commit that referenced this pull request Jun 27, 2023
added information that jest is not globally available

(cherry picked from commit f57e67f)
JReinhold pushed a commit that referenced this pull request Jun 27, 2023
added information that jest is not globally available

(cherry picked from commit f57e67f)
JReinhold pushed a commit that referenced this pull request Jun 27, 2023
added information that jest is not globally available

(cherry picked from commit f57e67f)
JReinhold pushed a commit that referenced this pull request Jun 27, 2023
added information that jest is not globally available

(cherry picked from commit f57e67f)
@JReinhold JReinhold added the patch:done Patch/release PRs already cherry-picked to main/release branch label Jun 27, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
documentation patch:done Patch/release PRs already cherry-picked to main/release branch patch:yes Bugfix & documentation PR that need to be picked to main branch
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants