Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Vue2: Source Decorator reactivity #23149

Merged
merged 2 commits into from
Jul 24, 2023

Conversation

chakAs3
Copy link
Contributor

@chakAs3 chakAs3 commented Jun 20, 2023

Closes #23132

What I did

How to test

Checklist

  • Make sure your changes are tested (stories and/or unit, integration, or end-to-end tests)
  • Make sure to add/update documentation regarding your changes
  • If you are deprecating/removing a feature, make sure to update
    MIGRATION.MD

Maintainers

  • If this PR should be tested against many or all sandboxes,
    make sure to add the ci:merged or ci:daily GH label to it.
  • Make sure this PR contains one of the labels below.

["cleanup", "BREAKING CHANGE", "feature request", "bug", "documentation", "maintenance", "dependencies", "other"]

@kasperpeulen
Copy link
Contributor

We will merge this in for the 7.2-alpha.

Copy link
Contributor

@kasperpeulen kasperpeulen left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@kasperpeulen kasperpeulen merged commit ba646e8 into next Jul 24, 2023
@kasperpeulen kasperpeulen deleted the chaks/vue2-source-snippet-reactivity branch July 24, 2023 14:38
@OssamaSijbesma
Copy link

@chakAs3 slots are still not reactive (Storybook v2.7.1), it is not updating the slot but an unrelated prop instead.

Screenshot 2023-08-03 162132

@chakAs3
Copy link
Contributor Author

chakAs3 commented Aug 5, 2023

hi @OssamaSijbesma for now slots reactivity is not supported in Vue2. Please open a new issue regarding this and mention me, so i can look at it.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

[Bug]: Code block does not react to controls changes for Vue components
3 participants